272372 – x11/foot: fails to build

Bug 272372 - x11/foot: fails to build

Summary: x11/foot: fails to build

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Jan Beich

URL:
Keywords:	regression

Depends on:
Blocks:	272342
	Show dependency tree / graph

Reported:	2023-07-04 20:51 UTC by Evgenii Khramtsov
Modified:	2023-07-04 23:57 UTC (History)
CC List:	0 users

See Also:

Flags:	jbeich: maintainer-feedback+ jbeich: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Evgenii Khramtsov 2023-07-04 20:51:53 UTC

../wayland.c:655:17: error: enumeration value 'XDG_TOPLEVEL_STATE_SUSPENDED'
 not handled in switch [-Werror,-Wswitch]
        switch (*state) {
                ^~~~~~
1 error generated.

Maybe backport https://codeberg.org/dnkl/foot/commit/72bc0acfbd4b ?

Comment 1 commit-hook freebsd_committer

2023-07-04 23:55:50 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bcea2e3a260297c7127041c29a166ab447feabb0

commit bcea2e3a260297c7127041c29a166ab447feabb0
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-07-04 23:52:49 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-07-04 23:54:33 +0000

    x11/foot: unbreak build after aec9c6c9cf90

    ../wayland.c:655:17: error: enumeration value 'XDG_TOPLEVEL_STATE_SUSPENDED' not handled in switch [-Werror,-Wswitch]
            switch (*state) {
                    ^

    PR:             272372

 x11/foot/Makefile | 4 ++++
 x11/foot/distinfo | 2 ++
 2 files changed, 6 insertions(+)

Comment 2 commit-hook freebsd_committer

2023-07-04 23:55:51 UTC

A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8f739e06f04a1547134695bd6af46c5307e160ce

commit 8f739e06f04a1547134695bd6af46c5307e160ce
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-07-04 23:52:49 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-07-04 23:54:52 +0000

    x11/foot: unbreak build after aec9c6c9cf90

    ../wayland.c:655:17: error: enumeration value 'XDG_TOPLEVEL_STATE_SUSPENDED' not handled in switch [-Werror,-Wswitch]
            switch (*state) {
                    ^

    PR:             272372
    (cherry picked from commit bcea2e3a260297c7127041c29a166ab447feabb0)

 x11/foot/Makefile | 4 ++++
 x11/foot/distinfo | 2 ++
 2 files changed, 6 insertions(+)

Comment 3 Jan Beich freebsd_committer

2023-07-04 23:57:27 UTC

Thanks, I forgot to check -Werror in my ports.

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!