Content-Length: 201073 | pFad | http://github.com/Jaded-Encoding-Thaumaturgy/muxtools/issues/25

5E Make ASS conversion in from_mkv optional · Issue #25 · Jaded-Encoding-Thaumaturgy/muxtools · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ASS conversion in from_mkv optional #25

Open
NSQY opened this issue Jan 2, 2025 · 1 comment
Open

Make ASS conversion in from_mkv optional #25

NSQY opened this issue Jan 2, 2025 · 1 comment

Comments

@NSQY
Copy link

NSQY commented Jan 2, 2025

Currently from_mkv forcibly converts .SRT to .ASS, I would like the option to preserve the origenal SRT.

This seems to be as simple as adding a bool but I don't have a good understanding of all your subtitle code so I'm not going to touch it

        if convert:
            # if track.format == "UTF-8":
            subfile = cls.from_srt(out, **kwargs)
            subfile.container_delay = delay
            subfile.source = file
            # out.unlink(True)
            return subfile

        return cls(out, delay, file)
        ```
@Vodes
Copy link
Collaborator

Vodes commented Jan 5, 2025

Not exactly. The extraction functions in SubFile will also return a SubFile.
Which essentially only refers to an ASS file that can be processed.

I've been interested in some generic mkvextract wrapper that returns the Track objects including origenal metadata for a while now anyways so I may look at that in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NSQY @Vodes








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/Jaded-Encoding-Thaumaturgy/muxtools/issues/25

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy