Content-Length: 218817 | pFad | http://github.com/JuliaGeo/Shapefile.jl/issues/107

AB `write` does not necesserily respect shapefile winding spec · Issue #107 · JuliaGeo/Shapefile.jl · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write does not necesserily respect shapefile winding spec #107

Open
rafaqz opened this issue Apr 1, 2024 · 1 comment
Open

write does not necesserily respect shapefile winding spec #107

rafaqz opened this issue Apr 1, 2024 · 1 comment
Assignees
@rafaqz
Labels
bug

Comments

@rafaqz
Copy link
Member

rafaqz commented Apr 1, 2024 •
edited
Loading

We are currently just calling getring and assuming they have the correct winding. Which will often not be true.

Probably a pretty serious bug.

I guess we need to detect the winding order of each ring in _get_parts for holes and exteriors separately, and then iterate either forwards or in reverse over the points depending.
@rafaqz rafaqz added the bug label Apr 1, 2024
@rafaqz
Copy link
Member Author

rafaqz commented Jun 13, 2024

We already have _isclockwise here we just need to run it on every ring as we stream the write, flipping the order we do GI.getpoint depending on the current order and if we need a hole or exterior. Maybe only a few extra lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaqz rafaqz

Labels
bug
Projects
JuliaCon 2024 Hackathon
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafaqz








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/JuliaGeo/Shapefile.jl/issues/107

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy