Content-Length: 249823 | pFad | http://github.com/JuulLabs/kable/issues/814

61 Inconsistent behavior between native and filtered ManufacturerData · Issue #814 · JuulLabs/kable · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent behavior between native and filtered ManufacturerData #814

Open
eygraber opened this issue Dec 6, 2024 · 5 comments · May be fixed by #842
Open

Inconsistent behavior between native and filtered ManufacturerData #814

eygraber opened this issue Dec 6, 2024 · 5 comments · May be fixed by #842
Labels
bug Something isn't working
Milestone
0.36.0

Comments

@eygraber
Copy link

eygraber commented Dec 6, 2024

Using 0.35.0-rc

If I use one Filter.ManufacturerData and I pass a single element ByteArray for both data and dataMask and everything works fine (the actual manufacturer data is 9 bytes).

If I use multiple Filter.ManufacturerData and I pass a single element ByteArray for both data and dataMask I get a crash saying that:

Data mask length (1) must match data length (9)

because Filter.ManufacturerData.matches(data: ByteArray?) calls requireDataAndMaskHaveSameLength using the actual manufacturer data (as opposed to the data parameter).
@twyatt
Copy link
Member

twyatt commented Dec 10, 2024 •
edited
Loading

Thanks for reporting!
Unfortunately I'm pretty swamped, so it may be a while before I can look into this.
PRs are also welcome.

@twyatt twyatt added the bug Something isn't working label Dec 10, 2024
@eygraber
Copy link
Author

I can send a PR, but I'm not sure what the correct behavior is supposed to be.

@twyatt twyatt linked a pull request Jan 20, 2025 that will close this issue
Open
@twyatt
Copy link
Member

twyatt commented Jan 20, 2025

@eygraber when you have a chance, can you test if the following SNAPSHOT fixes the issue for you (it is based on 0.35.0 release with #842 cherry-picked):

repositories {
    maven("https://oss.sonatype.org/content/repositories/snapshots")
}

dependencies {
    implementation("com.juul.kable:kable-core:0.35.0+issue814-SNAPSHOT")
}

@twyatt twyatt added this to the 0.36.0 milestone Jan 20, 2025
@eygraber
Copy link
Author

That fixes the issue for me, thanks!

@twyatt
Copy link
Member

twyatt commented Jan 20, 2025

Awesome, thanks for validating! This fix will ship in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.36.0
Development

Successfully merging a pull request may close this issue.

Allow for advertisement manufacturer data length to exceed filter data mask length JuulLabs/kable
2 participants
@twyatt @eygraber








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/JuulLabs/kable/issues/814

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy