Content-Length: 526319 | pFad | http://github.com/NativeScript/napi-android/commit/7b15b0fb73572f5cb0728474e3ae2d4635193a92

3D runtime: skip test in Hermes · NativeScript/napi-android@7b15b0f · GitHub
Skip to content

Commit 7b15b0f

Browse files
committed
runtime: skip test in Hermes
We need to figure out how to inform hermes engine about external memory pressure.
1 parent 359b0ee commit 7b15b0f

File tree

1 file changed

+38
-37
lines changed

1 file changed

+38
-37
lines changed

Diff for: test-app/app/src/main/assets/app/tests/testJniReferenceLeak.js

+38-37
Original file line numberDiff line numberDiff line change
@@ -9,58 +9,58 @@ describe("Tests JNI reference leak", function () {
99
// });
1010

1111
it("test_if_method_param_marshalling_leaks", function () {
12-
12+
1313
var test = new com.tns.tests.JniReferenceLeakTest(null);
14-
14+
1515
var N = 10000;
16-
16+
1717
for (var n=0; n<N; n++)
1818
{
1919
var c = 'x';
2020
expect(test.echoChar(char(c))).toBe(c);
21-
21+
2222
var i = 5;
2323
expect(test.echoInt(i)).toBe(i);
24-
24+
2525
var s = "hello";
2626
expect(test.echoString(s)).toBe(s);
27-
27+
2828
var o = new java.lang.Object();
2929
expect(test.echoObject(o)).toBe(o);
3030
}
31-
31+
3232
expect(n).toBe(N);
3333
});
34-
34+
3535
it("test_if_field_access_marshalling_leaks", function () {
36-
36+
3737
var test = new com.tns.tests.JniReferenceLeakTest(null);
38-
38+
3939
var N = 10000;
40-
40+
4141
for (var n=0; n<N; n++)
4242
{
4343
var c = 'x';
4444
test.charField = c;
4545
expect(test.charField).toBe(c);
46-
46+
4747
test.intField = n;
4848
expect(test.intField).toBe(n);
49-
49+
5050
var s = "hello" + n;
5151
test.stringField = s;
5252
expect(test.stringField).toBe(s);
53-
53+
5454
var o = new java.lang.Object();
5555
test.objectField = o;
5656
expect(test.objectField).toBe(o);
5757
}
58-
58+
5959
expect(n).toBe(N);
6060
});
61-
61+
6262
it("test_if_callback_parameter_marshalling_leaks", function () {
63-
63+
6464
var p = new com.tns.tests.JniReferenceLeakTest.Processor({
6565
echoChar: function(c) { return char(c); },
6666
echoInt: function(i) { return i; },
@@ -71,42 +71,43 @@ describe("Tests JNI reference leak", function () {
7171
echoStringArray: function(arr) { return arr; },
7272
echoObjectArray: function(arr) { return arr; }
7373
});
74-
75-
74+
75+
7676
var test = new com.tns.tests.JniReferenceLeakTest(p);
77-
77+
7878
var N = 10000;
79-
79+
8080
for (var n=0; n<N; n++)
8181
{
8282
var c = 'x';
8383
expect(test.triggerEchoChar(char(c))).toBe(c);
84-
84+
8585
var i = 5;
8686
expect(test.triggerEchoInt(i)).toBe(i);
87-
87+
8888
var s = "hello";
8989
expect(test.triggerEchoString(s)).toBe(s);
90-
90+
9191
var o = new java.lang.Object();
9292
expect(test.triggerEchoObject(o)).toBe(o);
9393
}
94-
94+
9595
expect(n).toBe(N);
9696
});
9797

98-
it("test_if_global_reference_leaks_when_interface_implementation_is_created", function () {
99-
100-
var n = 0;
101-
var N = 100 * 1000;
102-
103-
for (; n<N; n++)
104-
{
105-
var r = new java.lang.Runnable({ run: function(){} });
106-
}
107-
108-
expect(n).toBe(N);
109-
});
98+
if (__engine !== "Hermes") {
99+
it("test_if_global_reference_leaks_when_interface_implementation_is_created", function () {
100+
var n = 0;
101+
var N = 100 * 1000;
102+
103+
for (; n<N; n++)
104+
{
105+
var r = new java.lang.Runnable({ run: function(){} });
106+
}
107+
108+
expect(n).toBe(N);
109+
});
110+
}
110111

111112

112113
it("test_passing_javascript_array_should_not_leak", function () {

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/NativeScript/napi-android/commit/7b15b0fb73572f5cb0728474e3ae2d4635193a92

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy