Content-Length: 1403884 | pFad | http://github.com/NativeScript/nativescript-cli/commit/d6296f9637dc24718526eebbd5ba1cb403dba62e

F6 Remove fibers · NativeScript/nativescript-cli@d6296f9 · GitHub
Skip to content

Commit d6296f9

Browse files
Dimitar Kerezovrosen-vladimirov
Dimitar Kerezov
authored andcommittedJan 11, 2017
Remove fibers
This is a combination of 35 commits. Remove IFuture from function signatures - replace with async...Promise<T> Replace future wrapper in class-less functions Replace .wait with await Replace .wait with await vol 2 Replace .wait with await vol 3 Replace IFuture<T> with Promise<T> in .d.ts Replace Future.fromResult with async Mark IFuture functions without access modifiers as async Replace function..IFuture with async Promise ONE occurrence Mark execute functions as async...Promise<T> Mark lambdas as async Replace future.throw with reject Replace future.return with resolve Replace new Future with new Promise(resolve, reject) Revive lib/common Remove fibers from package.json Replace await return/await if with proper language Fix file in root of lib Fix lib/tools Fix lib/commands/plugin Fix lib/commands Fix files in lib/services up to test-execution-service.ts Fix all files in lib/providers Update package.json with required dependencies for testing. Fix tests from android-project-properties-manager to npm-support (inclusive) - all can be run successfully. Fix lib/device-sockets Fix test/platform-commands Fix services up until test-execution-service Fix test/platform-service Fix test/plugin-variables-service Fix test/lugins-service Fix test/project-commands Fix test/project-name-service Fix test/project-service test/project-templates-service Fix the rest of tests/ Fix error-reporting command
1 parent a5d42fa commit d6296f9

File tree

112 files changed

+5150
-5644
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

112 files changed

+5150
-5644
lines changed
 

Diff for: ‎lib/android-tools-info.ts

+179-205
Large diffs are not rendered by default.

Diff for: ‎lib/commands/add-platform.ts

+11-14
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,22 @@
11
export class AddPlatformCommand implements ICommand {
2+
public allowedParameters: ICommandParameter[] = [];
3+
24
constructor(private $platformService: IPlatformService,
35
private $errors: IErrors) { }
46

5-
execute(args: string[]): IFuture<void> {
6-
return (() => {
7-
this.$platformService.addPlatforms(args).wait();
8-
}).future<void>()();
7+
public async execute(args: string[]): Promise<void> {
8+
await this.$platformService.addPlatforms(args);
99
}
1010

11-
allowedParameters: ICommandParameter[] = [];
12-
13-
canExecute(args: string[]): IFuture<boolean> {
14-
return (() => {
15-
if(!args || args.length === 0) {
16-
this.$errors.fail("No platform specified. Please specify a platform to add");
17-
}
11+
public async canExecute(args: string[]): Promise<boolean> {
12+
if (!args || args.length === 0) {
13+
this.$errors.fail("No platform specified. Please specify a platform to add");
14+
}
1815

19-
_.each(args, arg => this.$platformService.validatePlatform(arg));
16+
_.each(args, arg => this.$platformService.validatePlatform(arg));
2017

21-
return true;
22-
}).future<boolean>()();
18+
return true;
2319
}
2420
}
21+
2522
$injector.registerCommand("platform|add", AddPlatformCommand);

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/NativeScript/nativescript-cli/commit/d6296f9637dc24718526eebbd5ba1cb403dba62e

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy