fix(google-mobile-ads): index types

NathanWalker · NathanWalker · commit 535648ab8629 · 2025-05-16T10:25:11.000-07:00
closes #625
diff --git a/packages/google-mobile-ads/README.md b/packages/google-mobile-ads/README.md
@@ -15,8 +15,8 @@ The `@nativescript/google-mobile-ads` plugin currently supports loading and disp
 - [@nativescript/google-mobile-ads](#nativescriptgoogle-mobile-ads)
 	- [Contents](#contents)
 	- [Installation](#installation)
-	- [Setup Admob for iOS](#setup-admob-for-ios)
-	- [Setup Admob for Android](#setup-admob-for-android)
+	- [Setup Mobile Ads for iOS](#setup-mobile-ads-for-ios)
+	- [Setup Mobile Ads for Android](#setup-mobile-ads-for-android)
 	- [Use @nativescript/google-mobile-ads](#use-nativescriptgoogle-mobile-ads)
 		- [1. Initialize the Mobile Ads SDK](#1-initialize-the-mobile-ads-sdk)
 		- [2. Add your preferred ad format to the app](#2-add-your-preferred-ad-format-to-the-app)
@@ -58,7 +58,7 @@ To install `@nativescript/google-mobile-ads`, run the following command in the r
 npm install @nativescript/google-mobile-ads
 ```
 
-## Setup Admob for iOS
+## Setup Mobile Ads for iOS
 
 Update your `Info.plist` file at `App_Resources/iOS` with a `GADApplicationIdentifier` key with a string value of your AdMob app ID ([identified in the AdMob UI](https://support.google.com/admob/answer/7356431)).
 
@@ -76,7 +76,7 @@ Also add the `NSUserTrackingUsageDescription` key.
 
 For more information about configuring the `Info.plist` and setting up your App ID, see [Update your Info.plist](https://developers.google.com/admob/ios/quick-start#update%5C_your%5C_infoplist).
 
-## Setup Admob for Android
+## Setup Mobile Ads for Android
 
 Add AdMob App ID ([identified in the AdMob UI](https://support.google.com/admob/answer/7356431)) to the app's `AndroidManifest.xml` file, found at `App_Resources/Android/src/main`. Failure to do so will result in a crash on app launch. Add the ID by adding a `<meta-data>` tag with name `com.google.android.gms.ads.APPLICATION_ID`, as shown below. For `android:value` insert your own AdMob App ID in quotes.
 
@@ -169,14 +169,14 @@ export function loadBanner(args) {
 
 #### Add Banner ad in NativeScript Angular
 
-Register the `BannerAd` view by adding its `AdmobModule` to the `imports` array of the `@NgModule` decorator of the component where you want to use the view.
+Register the `BannerAd` view by adding its `MobileAdsModule` to the `imports` array of the `@NgModule` decorator of the component where you want to use the view.
 
 ```ts
-import { AdmobModule } from '@nativescript/google-mobile-ads/angular';
+import { MobileAdsModule } from '@nativescript/google-mobile-ads/angular';
 
 @NgModule({
     imports: [
-    AdmobModule
+    	MobileAdsModule
     ],
     declarations: [
         AppComponent
@@ -201,11 +201,11 @@ Register the `BannerAd` view in the `app.ts` file as follows:
 
 ```ts
 import { createApp } from 'nativescript-vue';
-import Admob from '@nativescript/google-mobile-ads/vue';
+import MobileAds from '@nativescript/google-mobile-ads/vue';
 import Home from './components/Home.vue';
 
 const app = createApp(Home);
-app.use(Admob);
+app.use(MobileAds);
 ```
 
 And then add it to markup as follows. The `BannerAd` requires the following attributes to be set:
@@ -424,7 +424,7 @@ To add a Native ad to your {N} Core app, follow these steps:
 
 ```xml
 <Page xmlns:ui="@nativescript/google-mobile-ads">
-  <ActionBar title="Admob" />
+  <ActionBar title="Mobile Ads" />
   <StackLayout>
     <ui:NativeAdView height="400" loaded="{{nativeAdLoaded}}" />
   </StackLayout>
@@ -709,7 +709,7 @@ If the tags to enable the Child-directed setting and `tagForUnderAgeOfConsent`ar
 
 This setting can be set via `RequestConfiguration.maxAdContentRating`:
 
-AdMob ads returned for these requests have a content rating at or below that level. The possible values for this network extra are based on [digital content label classifications](https://support.google.com/admob/answer/7562142), and should be one of the following MaxAdContentRating objects:
+Mobile ads returned for these requests have a content rating at or below that level. The possible values for this network extra are based on [digital content label classifications](https://support.google.com/admob/answer/7562142), and should be one of the following MaxAdContentRating objects:
 
 - MaxAdContentRating.G
 - MaxAdContentRating.PG
diff --git a/packages/google-mobile-ads/angular/index.ts b/packages/google-mobile-ads/angular/index.ts
@@ -13,9 +13,8 @@ export * from './media-view-directive';
 	declarations: [BannerAdDirective, NativeAdViewDirective, MediaViewDirective],
 	exports: [BannerAdDirective, NativeAdViewDirective, MediaViewDirective],
 })
-// @ts-ignore
-export class AdmobModule {}
+export class MobileAdsModule {}
 
-registerElement('NativeAdView', () => require('@nativescript/firebase-admob').NativeAdView);
-registerElement('BannerAd', () => require('@nativescript/firebase-admob').BannerAd);
-registerElement('MediaView', () => require('@nativescript/firebase-admob').MediaView);
+registerElement('NativeAdView', () => require('@nativescript/google-mobile-ads').NativeAdView);
+registerElement('BannerAd', () => require('@nativescript/google-mobile-ads').BannerAd);
+registerElement('MediaView', () => require('@nativescript/google-mobile-ads').MediaView);
diff --git a/packages/google-mobile-ads/angular/package.json b/packages/google-mobile-ads/angular/package.json
@@ -1,3 +1,3 @@
 {
-	"name": "nativescript-firebase-admob-angular"
+	"name": "nativescript-google-mobile-ads-angular"
 }
diff --git a/packages/google-mobile-ads/angular/tsconfig.angular.json b/packages/google-mobile-ads/angular/tsconfig.angular.json
@@ -4,7 +4,7 @@
 		"types": ["node"],
 		"baseUrl": ".",
 		"paths": {
-			"@nativescript/firebase-admob": ["../../../dist/packages/firebase-admob"]
+			"@nativescript/google-mobile-ads": ["../../../dist/packages/google-mobile-ads"]
 		},
 		"outDir": "../../../dist/out-tsc",
 		"declarationDir": "../../../dist/out-tsc"
diff --git a/packages/google-mobile-ads/index.d.ts b/packages/google-mobile-ads/index.d.ts
@@ -1,4 +1,4 @@
-import { IAdmob, IInterstitialAd, IRewardedAd, BannerAdBase, IRewardedInterstitialAd, RewardedAdEventType, MaxAdContentRating, ServerSideVerificationOptions } from './common';
+import { IInterstitialAd, IRewardedAd, BannerAdBase, BannerAdSizeBase, IRewardedInterstitialAd, RewardedAdEventType, MaxAdContentRating, ServerSideVerificationOptions } from './common';
 
 export { MaxAdContentRating, RewardedAdEventType };
 
@@ -173,11 +173,11 @@ export declare class BannerAd extends BannerAdBase {
 
 	isLoading(): boolean;
 
-	on(event: 'adClicked', callback: (args: any) => void, thisArg?: any);
-	on(event: 'adLoaded', callback: (args: any) => void, thisArg?: any);
-	on(event: 'adClosed', callback: (args: any) => void, thisArg?: any);
-	on(event: 'adImpression', callback: (args: any) => void, thisArg?: any);
-	on(event: 'adFailedToLoad', callback: (args: any) => void, thisArg?: any);
+	on(event: 'adClicked', callback: (args: any) => void, thisArg?: any): any;
+	on(event: 'adLoaded', callback: (args: any) => void, thisArg?: any): any;
+	on(event: 'adClosed', callback: (args: any) => void, thisArg?: any): any;
+	on(event: 'adImpression', callback: (args: any) => void, thisArg?: any): any;
+	on(event: 'adFailedToLoad', callback: (args: any) => void, thisArg?: any): any;
 }
 
 export declare class BannerAdSize extends BannerAdSizeBase {
@@ -201,21 +201,21 @@ export declare class BannerAdSize extends BannerAdSizeBase {
 
 	static readonly SEARCH: BannerAdSize;
 
-	static createAnchoredAdaptiveBanner(width: number, orientation: 'portrait' | 'landscape' | 'device' = 'device'): BannerAdSize;
+	static createAnchoredAdaptiveBanner(width: number, orientation: 'portrait' | 'landscape' | 'device'): BannerAdSize;
 
-	static createInLineAdaptiveBanner(width: number, maxHeight: number = 0, orientation: 'portrait' | 'landscape' | 'device' = 'device'): BannerAdSize;
+	static createInLineAdaptiveBanner(width: number, maxHeight: number, orientation: 'portrait' | 'landscape' | 'device'): BannerAdSize;
 
 	readonly native: any;
 	readonly android: any;
 	readonly ios: any;
 }
 
-export declare class Admob implements IAdmob {
+export declare class MobileAds implements IMobileAds {
 	readonly app: any;
 
 	static init(): Promise<{ [key: string]: AdapterStatus }>;
 
-	static getInstance(): Admob;
+	static getInstance(): MobileAds;
 
 	requestConfiguration: RequestConfiguration;
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "name": "nativescript-firebase-admob-angular"`
	`2`	`+ "name": "nativescript-google-mobile-ads-angular"`
`3`	`3`	`}`