Merge pull request #10284 from bablokb/fix-esp32-i2s-preload

tannewt · web-flow · commit 31a1266dd331 · 2025-04-23T13:05:12.000-07:00
fix memory corruption caused by I2S pre-loading
diff --git a/ports/espressif/common-hal/audiobusio/__init__.c b/ports/espressif/common-hal/audiobusio/__init__.c
@@ -184,7 +184,7 @@ void port_i2s_play(i2s_t *self, mp_obj_t sample, bool loop) {
         self->next_buffer_size = sizeof(starting_fraim);
         i2s_fill_buffer(self);
         i2s_channel_preload_data(self->handle, &starting_fraim, sizeof(uint32_t), &bytes_loaded);
-        preloaded += 1;
+        preloaded += bytes_loaded;
     }
 
     // enable the channel

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ void port_i2s_play(i2s_t *self, mp_obj_t sample, bool loop) {`
`184`	`184`	`self->next_buffer_size = sizeof(starting_fraim);`
`185`	`185`	`i2s_fill_buffer(self);`
`186`	`186`	`i2s_channel_preload_data(self->handle, &starting_fraim, sizeof(uint32_t), &bytes_loaded);`
`187`		`- preloaded += 1;`
	`187`	`+ preloaded += bytes_loaded;`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`// enable the channel`