Remove audiofilters.DistortionMode.ATAN

relic-se · relic-se · commit 3a16dafef897 · 2024-10-31T10:44:05.000-05:00
diff --git a/shared-bindings/audiofilters/Distortion.c b/shared-bindings/audiofilters/Distortion.c
@@ -22,9 +22,6 @@
 //|     CLIP: DistortionMode
 //|     """Digital distortion effect which cuts off peaks at the top and bottom of the waveform."""
 //|
-//|     ATAN: DistortionMode
-//|     """"""
-//|
 //|     LOFI: DistortionMode
 //|     """Low-resolution digital distortion effect (bit depth reduction). You can use it to emulate the sound of early digital audio devices."""
 //|
@@ -36,14 +33,12 @@
 //|
 
 MAKE_ENUM_VALUE(audiofilters_distortion_mode_type, distortion_mode, CLIP, DISTORTION_MODE_CLIP);
-MAKE_ENUM_VALUE(audiofilters_distortion_mode_type, distortion_mode, ATAN, DISTORTION_MODE_ATAN);
 MAKE_ENUM_VALUE(audiofilters_distortion_mode_type, distortion_mode, LOFI, DISTORTION_MODE_LOFI);
 MAKE_ENUM_VALUE(audiofilters_distortion_mode_type, distortion_mode, OVERDRIVE, DISTORTION_MODE_OVERDRIVE);
 MAKE_ENUM_VALUE(audiofilters_distortion_mode_type, distortion_mode, WAVESHAPE, DISTORTION_MODE_WAVESHAPE);
 
 MAKE_ENUM_MAP(audiofilters_distortion_mode) {
     MAKE_ENUM_MAP_ENTRY(distortion_mode, CLIP),
-    MAKE_ENUM_MAP_ENTRY(distortion_mode, ATAN),
     MAKE_ENUM_MAP_ENTRY(distortion_mode, LOFI),
     MAKE_ENUM_MAP_ENTRY(distortion_mode, OVERDRIVE),
     MAKE_ENUM_MAP_ENTRY(distortion_mode, WAVESHAPE),
diff --git a/shared-module/audiofilters/Distortion.c b/shared-module/audiofilters/Distortion.c
@@ -276,12 +276,7 @@ audioio_get_buffer_result_t audiofilters_distortion_get_buffer(audiofilters_dist
 
                 // Pre-calculate drive-based constants if needed by effect mode
                 mp_float_t word_mult = 0;
-                mp_float_t word_div = 0;
                 switch (self->mode) {
-                    case DISTORTION_MODE_ATAN:
-                        word_mult = powf(10.0, drive * drive * 3.0) - 1.0 + 0.001;
-                        word_div = 1.0 / (atanf(word_mult) * (1.0 + drive * 8));
-                        break;
                     case DISTORTION_MODE_LOFI:
                         word_mult = powf(2.0, 2.0 + (1.0 - drive) * 14); // goes from 16 to 2 bits
                         break;
@@ -309,9 +304,6 @@ audioio_get_buffer_result_t audiofilters_distortion_get_buffer(audiofilters_dist
                             word = powf(fabs(word / 32768.0), 1.0001 - drive) * word_sign * 32767.0;
                             word = MIN(MAX(word, -32767), 32768); // Hard clip
                         } break;
-                        case DISTORTION_MODE_ATAN: {
-                            word = atanf(word / 32768.0 * word_mult) * word_div * 32767.0;
-                        } break;
                         case DISTORTION_MODE_LOFI: {
                             word = floorf(word / 32768.0 * word_mult + 0.5) / word_mult * 32767.0;
                         } break;
diff --git a/shared-module/audiofilters/Distortion.h b/shared-module/audiofilters/Distortion.h
@@ -13,7 +13,6 @@
 
 typedef enum {
     DISTORTION_MODE_CLIP,
-    DISTORTION_MODE_ATAN,
     DISTORTION_MODE_LOFI,
     DISTORTION_MODE_OVERDRIVE,
     DISTORTION_MODE_WAVESHAPE,
