Always update echo_buffer_len during recalculate_delay.

relic-se · relic-se · commit 47c9fc1f356c · 2025-04-14T20:04:58.000-05:00
diff --git a/shared-module/audiodelays/Echo.c b/shared-module/audiodelays/Echo.c
@@ -136,16 +136,12 @@ void recalculate_delay(audiodelays_echo_obj_t *self, mp_float_t f_delay_ms) {
         // Calculate the current echo buffer length in bytes
         uint32_t new_echo_buffer_len = (uint32_t)(self->base.sample_rate / MICROPY_FLOAT_CONST(1000.0) * f_delay_ms) * (self->base.channel_count * sizeof(uint16_t));
 
-        // Check if our new echo is too long for our maximum buffer
+        // Limit to valid range
         if (new_echo_buffer_len > self->max_echo_buffer_len) {
-            return;
-        } else if (new_echo_buffer_len < 0.0) { // or too short!
-            return;
-        }
-
-        // If the echo buffer is larger then our audio buffer weird things happen
-        if (new_echo_buffer_len < self->buffer_len) {
-            return;
+            new_echo_buffer_len = self->max_echo_buffer_len;
+        } else if (new_echo_buffer_len < self->buffer_len) {
+            // If the echo buffer is smaller than our audio buffer, weird things happen
+            new_echo_buffer_len = self->buffer_len;
         }
 
         self->echo_buffer_len = new_echo_buffer_len;
