Decode now takes &[u8], per @adamcrume's suggestion

squidpickles · squidpickles · commit 4a1b62053e8a · 2017-04-25T10:12:06.000-07:00
diff --git a/src/lib.rs b/src/lib.rs
@@ -157,7 +157,7 @@ impl<'a, R: Read> NaturalLines<'a, R> {
     }
   }
 
-  fn decode(&self, buf: &Vec<u8>) -> Result<NaturalLine, PropertiesError> {
+  fn decode(&self, buf: &[u8]) -> Result<NaturalLine, PropertiesError> {
     match self.encoding.decode(buf, DecoderTrap::Strict) {
       Ok(s) => Ok(NaturalLine(self.line_count, s)),
       Err(_) => Err(PropertiesError::new(&format!("Error reading {} encoding", self.encoding.name()), None, Some(self.line_count))),

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ impl<'a, R: Read> NaturalLines<'a, R> {`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`160`		`- fn decode(&self, buf: &Vec<u8>) -> Result<NaturalLine, PropertiesError> {`
	`160`	`+ fn decode(&self, buf: &[u8]) -> Result<NaturalLine, PropertiesError> {`
`161`	`161`	`match self.encoding.decode(buf, DecoderTrap::Strict) {`
`162`	`162`	`Ok(s) => Ok(NaturalLine(self.line_count, s)),`
`163`	`163`	`Err(_) => Err(PropertiesError::new(&format!("Error reading {} encoding", self.encoding.name()), None, Some(self.line_count))),`