build: update common's locales to use rules_js

josephperrott · josephperrott · commit 4abaef282558 · 2025-05-23T13:59:00.000Z
Use ts_project to build the common locales
diff --git a/packages/bazel/test/ng_package/common_package.spec.ts b/packages/bazel/test/ng_package/common_package.spec.ts
@@ -23,12 +23,12 @@ describe('@angular/common ng_package', () => {
     it('/locales', () => {
       const files = shx.ls('locales').stdout.split('\n');
       expect(files.some((n) => n.endsWith('.d.ts'))).toBe(true, `.d.ts files don't exist`);
-      expect(files.some((n) => n.endsWith('.mjs'))).toBe(true, `.mjs files don't exist`);
+      expect(files.some((n) => n.endsWith('.js'))).toBe(true, `.js files don't exist`);
     });
     it('/locales/extra', () => {
       const files = shx.ls('locales/extra').stdout.split('\n');
       expect(files.some((n) => n.endsWith('.d.ts'))).toBe(true, `.d.ts files don't exist`);
-      expect(files.some((n) => n.endsWith('.mjs'))).toBe(true, `.mjs files don't exist`);
+      expect(files.some((n) => n.endsWith('.js'))).toBe(true, `.js files don't exist`);
     });
   });
 
@@ -98,7 +98,7 @@ describe('@angular/common ng_package', () => {
           typings: `./index.d.ts`,
           exports: matchesObjectWithOrder({
             './locales/global/*': {default: './locales/global/*.js'},
-            './locales/*': {types: './locales/*.d.ts', default: './locales/*.mjs'},
+            './locales/*': {types: './locales/*.d.ts', default: './locales/*.js'},
             './package.json': {default: './package.json'},
             '.': {
               types: './index.d.ts',
diff --git a/packages/common/locales/BUILD.bazel b/packages/common/locales/BUILD.bazel
@@ -1,6 +1,7 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "generated_file_test")
 load("//packages/common/locales:index.bzl", "LOCALES", "generate_all_locale_files", "generate_closure_locale_file")
-load("//tools:defaults.bzl", "pkg_npm", "ts_library")
+load("//tools:defaults.bzl", "pkg_npm")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -23,7 +24,7 @@ generate_all_locale_files(
     name = "locale_files",
 )
 
-ts_library(
+ts_project(
     name = "locales",
     # TODO(devversion): Remove glob for checked-in legacy locale files that haven't been
     # removed in the past (when CLDR has been updated). These can be removed in a major.
diff --git a/packages/common/locales/generate-locales-tool/BUILD.bazel b/packages/common/locales/generate-locales-tool/BUILD.bazel
@@ -1,16 +1,25 @@
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_config", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_config(
+    name = "tsconfig_build",
+    src = "tsconfig.json",
+    deps = [
+        "//:node_modules/@types/node",
+        "//packages:tsconfig_build",
+    ],
+)
+
+ts_project(
     name = "generate-locales-tool",
     srcs = glob(["*.ts"]),
     deps = [
-        "@npm//@bazel/runfiles",
-        "@npm//@types/cldrjs",
-        "@npm//@types/node",
-        "@npm//cldr",
-        "@npm//cldrjs",
-        "@npm//tinyglobby",
+        "//:node_modules/@bazel/runfiles",
+        "//:node_modules/@types/cldrjs",
+        "//:node_modules/@types/node",
+        "//:node_modules/cldr",
+        "//:node_modules/cldrjs",
+        "//:node_modules/tinyglobby",
     ],
 )
diff --git a/packages/common/locales/generate-locales-tool/bin/BUILD.bazel b/packages/common/locales/generate-locales-tool/bin/BUILD.bazel
@@ -1,4 +1,5 @@
-load("//tools:defaults.bzl", "nodejs_binary", "ts_library")
+load("//tools:defaults.bzl", "nodejs_binary")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -9,12 +10,14 @@ BIN_ENTRYPOINTS = [
     "write-locale-files-to-dist",
 ]
 
-ts_library(
+ts_project(
     name = "bin",
     srcs = glob(["*.ts"]),
-    deps = [
+    interop_deps = [
         "//packages/common/locales/generate-locales-tool",
-        "@npm//@types/node",
+    ],
+    deps = [
+        "//:node_modules/@types/node",
     ],
 )
 
@@ -25,5 +28,5 @@ ts_library(
         "@cldr_json_data//:all_json",
         "@cldr_xml_data//:all_xml",
     ],
-    entry_point = ":%s.ts" % entrypoint,
+    entry_point = ":%s.js" % entrypoint,
 ) for entrypoint in BIN_ENTRYPOINTS]
diff --git a/packages/common/locales/generate-locales-tool/tsconfig.json b/packages/common/locales/generate-locales-tool/tsconfig.json
@@ -0,0 +1,6 @@
+{
+  "extends": "../../../tsconfig-build.json",
+  "compilerOptions": {
+    "types": ["node"],
+  }
+}
diff --git a/packages/common/package.json b/packages/common/package.json
@@ -17,7 +17,7 @@
     },
     "./locales/*": {
       "types": "./locales/*.d.ts",
-      "default": "./locales/*.mjs"
+      "default": "./locales/*.js"
     }
   },
   "peerDependencies": {
diff --git a/tools/defaults2.bzl b/tools/defaults2.bzl
@@ -28,6 +28,9 @@ def _determine_tsconfig(testonly):
     if native.package_name().startswith("packages/language-service"):
         return "//packages:tsconfig_test" if testonly else "//packages/language-service:tsconfig_build"
 
+    if native.package_name().startswith("packages/common/locales/generate-locales-tool"):
+        return "//packages:tsconfig_test" if testonly else "//packages/common/locales/generate-locales-tool:tsconfig_build"
+
     if native.package_name().startswith("packages"):
         return "//packages:tsconfig_test" if testonly else "//packages:tsconfig_build"
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`},`
`18`	`18`	`"./locales/*": {`
`19`	`19`	`"types": "./locales/*.d.ts",`
`20`		`- "default": "./locales/*.mjs"`
	`20`	`+ "default": "./locales/*.js"`
`21`	`21`	`}`
`22`	`22`	`},`
`23`	`23`	`"peerDependencies": {`