refactor(core): drop computation error messages in production

arturovt · arturovt · commit bb955436e094 · 2025-04-02T18:58:23.000+03:00
Some of the error messages in `core/primitives` are already guarded with `ngDevMode`; this change guards the remaining ones.
diff --git a/packages/core/primitives/signals/src/computed.ts b/packages/core/primitives/signals/src/computed.ts
@@ -133,7 +133,9 @@ const COMPUTED_NODE = /* @__PURE__ */ (() => {
     producerRecomputeValue(node: ComputedNode<unknown>): void {
       if (node.value === COMPUTING) {
         // Our computation somehow led to a cyclic read of itself.
-        throw new Error('Detected cycle in computations.');
+        throw new Error(
+          typeof ngDevMode !== 'undefined' && ngDevMode ? 'Detected cycle in computations.' : '',
+        );
       }
 
       const oldValue = node.value;
diff --git a/packages/core/primitives/signals/src/linked_signal.ts b/packages/core/primitives/signals/src/linked_signal.ts
@@ -137,7 +137,9 @@ export const LINKED_SIGNAL_NODE = /* @__PURE__ */ (() => {
     producerRecomputeValue(node: LinkedSignalNode<unknown, unknown>): void {
       if (node.value === COMPUTING) {
         // Our computation somehow led to a cyclic read of itself.
-        throw new Error('Detected cycle in computations.');
+        throw new Error(
+          typeof ngDevMode !== 'undefined' && ngDevMode ? 'Detected cycle in computations.' : '',
+        );
       }
 
       const oldValue = node.value;
diff --git a/packages/core/primitives/signals/src/watch.ts b/packages/core/primitives/signals/src/watch.ts
@@ -99,7 +99,11 @@ export function createWatch(
     }
 
     if (isInNotificationPhase()) {
-      throw new Error(`Schedulers cannot synchronously execute watches while scheduling.`);
+      throw new Error(
+        typeof ngDevMode !== 'undefined' && ngDevMode
+          ? 'Schedulers cannot synchronously execute watches while scheduling.'
+          : '',
+      );
     }
 
     node.dirty = false;

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,11 @@ export function createWatch(`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`if (isInNotificationPhase()) {`
`102`		- throw new Error(`Schedulers cannot synchronously execute watches while scheduling.`);
	`102`	`+ throw new Error(`
	`103`	`+ typeof ngDevMode !== 'undefined' && ngDevMode`
	`104`	`+ ? 'Schedulers cannot synchronously execute watches while scheduling.'`
	`105`	`+ : '',`
	`106`	`+ );`
`103`	`107`	`}`
`104`	`108`
`105`	`109`	`node.dirty = false;`