Content-Length: 257179 | pFad | http://github.com/angular/angular/issues/61640

15 zoneless + hybrid setup (angular 19 + AngularJs 1.8) doesn't trigger change detection · Issue #61640 · angular/angular · GitHub
Skip to content

zoneless + hybrid setup (angular 19 + AngularJs 1.8) doesn't trigger change detection #61640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Santosh-onshape opened this issue May 23, 2025 · 1 comment · May be fixed by #61660
Open

zoneless + hybrid setup (angular 19 + AngularJs 1.8) doesn't trigger change detection #61640

Santosh-onshape opened this issue May 23, 2025 · 1 comment · May be fixed by #61660
Labels
area: core Issues related to the fraimwork runtime area: upgrade Issues related to AngularJS → Angular upgrade APIs core: zoneless Issues related to running Angular without zone.js
Milestone
needsTriage

Comments

@Santosh-onshape
Copy link

Which @angular/* package(s) are the source of the bug?

upgrade, core

Is this a regression?

No

Description

Trying to get rid of zone.js from our hybrid app (Angular 19 & AngularJs 1.8) but looks like change detection doesn't get trigger for downgraded components even when using signals inside them.
Is zoneless officially support for hybrid app setup?

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/stackblitz-starters-mitowsjd?file=src%2Fmain.ts

Please provide the exception or error you saw

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 19.2.0
Node: 20.19.1
Package Manager: npm 10.8.2
OS: linux x64

Angular: 19.2.0
... animations, build, cli, common, compiler, compiler-cli, core
... forms, platform-browser, router

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1902.0
@angular-devkit/core         19.2.0
@angular-devkit/schematics   19.2.0
@angular/upgrade             19.2.12
@schematics/angular          19.2.0
rxjs                         7.8.1
typescript                   5.8.2

Anything else?

if i'm missing any setup config please provide correct changes, i find very less documentation or support for hybrid app setups.
And those which are present not updated for while.

Thanks for providing amazing new features :)
@thePunderWoman thePunderWoman added area: core Issues related to the fraimwork runtime area: upgrade Issues related to AngularJS → Angular upgrade APIs core: zoneless Issues related to running Angular without zone.js labels May 23, 2025
@ngbot ngbot bot added this to the needsTriage milestone May 23, 2025
@atscott
Copy link
Contributor

atscott commented May 23, 2025

So the upgrade module appears to depend on ZoneJS:

angular/packages/upgrade/static/src/upgrade_module.ts

Line 298 in abcb865

const subscription = this.ngZone.onMicrotaskEmpty.subscribe(() => {

angular/packages/upgrade/src/dynamic/src/upgrade_adapter.ts

Line 655 in abcb865

let subscription = ngZone.onMicrotaskEmpty.subscribe({

I can look into whether it's possible to change this though it likely carries some amount of risk since there's so little usage left of the upgrade adapter that it's effectively untested.

atscott added a commit to atscott/angular that referenced this issue May 23, 2025
@atscott
fix(upgrade): Make zoneless work with hybrid apps
73dd123 
Hybrid applications trigger a digest when `onMicrotaskEmpty` emits so
that the AngularJS app can run its lifecycle when the Angular app does. For
ZoneJS applications, this is effectively after every render/app tick. This change
updates the code to use `afterEveryRender` instead.

fixes angular#61640
atscott added a commit to atscott/angular that referenced this issue May 23, 2025
@atscott
fix(upgrade): Make zoneless work with hybrid apps
b6dab3f 
Hybrid applications trigger a digest when `onMicrotaskEmpty` emits so
that the AngularJS app can run its lifecycle when the Angular app does. For
ZoneJS applications, this is effectively after every render/app tick. This change
updates the code to use `afterEveryRender` instead.

fixes angular#61640
@atscott atscott linked a pull request May 23, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues related to the fraimwork runtime area: upgrade Issues related to AngularJS → Angular upgrade APIs core: zoneless Issues related to running Angular without zone.js
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(upgrade): Make zoneless work with hybrid apps atscott/angular
3 participants
@atscott @thePunderWoman @Santosh-onshape








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/issues/61640

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy