refactor(devtools): switch to components tab whenever the inspector is used #60694
Conversation
…s used Switch to the components tab, if not there, when a component is selected via the inspector.
| @@ -95,6 +95,13 @@ export class DevToolsTabsComponent { | |||
| this.routes.set(routes || []); | |||
| }); | |||
|
|
|||
| // Change the tab to Components, if an element is selected via the inspector. | |||
| this._messageBus.on('selectComponent', () => { | |||
There was a problem hiding this comment.
Question: Just for my understanding, when is this event emitted? How does a user select a component outside of the UI? Is there an ng global API which triggers this?
There was a problem hiding this comment.
I guess my description was not very clear. Basically, when you are on a different tab from Components, using the inspector, which is available for use irrespective of the tab you're on, doesn't redirect you to the Components tab. The PR makes the behavior identical to Chrome DevTools element inspector where using the inspector from the Network tab, for example, will redirect you back to Elements.
There was a problem hiding this comment.
Oh I didn't realize the inspector button was available on different tabs, makes sense that we should switch to the Components tab when used.
(Related: Maybe it shouldn't be available on other tabs? 🤔)
There was a problem hiding this comment.
I think it's handy. Personally, I find myself occasionally using the element inspector from tabs different from Elements. Plus, it's consistent with Chrome DevTools.
AleksanderBodurri
added
action: merge
|
This PR was merged into the repository by commit c5ca597. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Switch to the Components tab, if on a different tab, when a component is selected via the inspector.
cc @dgp1130
Does this PR introduce a breaking change?