Content-Length: 189463 | pFad | http://github.com/balena-io-experimental/meetbot/issues/72

5A Abstract out Google services authentication · Issue #72 · balena-io-experimental/meetbot · GitHub
Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Abstract out Google services authentication #72

Open
vipulgupta2048 opened this issue Feb 16, 2022 · 0 comments
Open

Abstract out Google services authentication #72

vipulgupta2048 opened this issue Feb 16, 2022 · 0 comments

Comments

@vipulgupta2048
Copy link
Member

I don't really like how complex the Google authentication is. This function checks for credentials but the GoogleCalendar implementation also performs some authentication (creating as token). It's become hard to follow how authentication is done so if a token.json file is what all these google APIs use then I think 1 single place should create it and the rest of the code doesn't have to always check if it exists and create if not...not worth doing in this PR but wanted to mention my thoughts about this.

Originally posted by @20k-ultra in #56 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/balena-io-experimental/meetbot/issues/72

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy