Content-Length: 292727 | pFad | http://github.com/coder/code-server/issues/5118

0D [Feat]: Add option to disable "Show Local" while saving · Issue #5118 · coder/code-server · GitHub
Skip to content

[Feat]: Add option to disable "Show Local" while saving #5118

@avsthiago-kbc

Description

@avsthiago-kbc

What is your suggestion?

Reuse the option --disable-file-downloads recently implemented on #5055 to remove the Show Local button when using the Save As option. This option allows the users to save the current file on their local machine.

Example:
Screenshot 2022-04-19 at 14 53 51

Why do you want this feature?

One could argue that having the option to save the file locally makes the download as accessible as having the Download button when right clicking the file name. As mentioned in the comments on the issue #1386, some industries have concerns about downloading files from the IDE.

Are there any workarounds to get this functionality today?

Not that I'm aware of.

How this feature could be implemented?

We could extend the code implemented on #5055. The value of the option --disable-file-downloads could be used within a condition that will either add the "Show Local" button or not. As I understand, the button is added on simpleFileDialog.ts L279. Disclaimer, I'm not familiar with the code base, neither TypeScript, so there might be more places we will need patch.

Are you interested in submitting a PR for this?

Yes, but I might need some guidance setting up the environment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: http://github.com/coder/code-server/issues/5118

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy