Content-Length: 211898 | pFad | http://github.com/conversejs/converse.js/issues/3496

9D CSS classes added to chat-area and converse-muc-sidebar are not adapted to embedded view mode. · Issue #3496 · conversejs/converse.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS classes added to chat-area and converse-muc-sidebar are not adapted to embedded view mode. #3496

Open
JohnXLivingston opened this issue Sep 2, 2024 · 0 comments
Labels
UI User interface
Milestone

Comments

@JohnXLivingston
Copy link
Contributor

JohnXLivingston commented Sep 2, 2024

Describe the bug

When Converse is used in embedded mode, the viewport size gives no information about the available size for Converse.

These lines:

if (view_mode === 'overlayed') {
chat_area_classes = 'd-none d-md-flex col-s-10 col-md-8';
sidebar_classes = 'col-xs-12 col-s-2 col-md-4';
} else {
chat_area_classes = 'd-none d-md-flex col-md-8 col-xl-10';
sidebar_classes = 'col-xs-12 col-md-4 col-xl-2';
}

    if (view_mode === 'overlayed') {
        chat_area_classes = 'd-none d-md-flex col-s-10 col-md-8';
        sidebar_classes = 'col-xs-12 col-s-2 col-md-4';
    } else {
        chat_area_classes = 'd-none d-md-flex col-md-8 col-xl-10';
        sidebar_classes = 'col-xs-12 col-md-4 col-xl-2';
    }

These lines relies on the viewport size to change the width of the muc sidebar (and sometime hide the chat area).

But as said, in embedded view mode, the viewport gives little information on the chat width.
You can for example have a 1480*1024 viewport, but only 400*800 for the embedded chat.

Expected behavior

These classes should not be used in embedded mode.
Flex should automatically resize chat area and muc sidebar.

@jcbrand jcbrand added the UI User interface label Sep 12, 2024
@jcbrand jcbrand added this to the 11.0.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface
Projects
None yet
Development

No branches or pull requests

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/conversejs/converse.js/issues/3496

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy