Content-Length: 374773 | pFad | http://github.com/cvg/limap/pull/88/commits/586c5c0434ccac7f09f9b84577670f2da2c9826b

71 Switch to ruff with linting by B1ueber2y · Pull Request #88 · cvg/limap · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff with linting #88

Merged
merged 10 commits into from
Oct 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting.
  • Loading branch information
B1ueber2y committed Oct 19, 2024
commit 586c5c0434ccac7f09f9b84577670f2da2c9826b
2 changes: 1 addition & 1 deletion ruff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ select = [
# isort
"I",
]
ignore = ["SIM117"]
ignore = ["SIM117", "F401"]

[lint.per-file-ignores]
"scripts/*.py" = ["E"]
2 changes: 1 addition & 1 deletion runners/rome16k/triangulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def parse_config():
cfg["list_path"] = args.list_path
cfg["model_path"] = args.model_path
cfg["info_path"] = args.info_path
if ("max_image_dim" not in cfg.keys()) or args.max_image_dim is not None:
if ("max_image_dim" not in cfg) or args.max_image_dim is not None:
cfg["max_image_dim"] = args.max_image_dim
# components
cfg["component_folder"] = args.component_folder
Expand Down
2 changes: 1 addition & 1 deletion runners/visualsfm_triangulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def parse_config():
cfg["vsfm_path"] = args.vsfm_path
cfg["nvm_file"] = args.nvm_file
cfg["info_path"] = args.info_path
if ("max_image_dim" not in cfg.keys()) or args.max_image_dim is not None:
if ("max_image_dim" not in cfg) or args.max_image_dim is not None:
cfg["max_image_dim"] = args.max_image_dim
return cfg

Expand Down
3 changes: 1 addition & 2 deletions scripts/eval_hypersim.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,7 @@ def eval_hypersim(
[line.as_array() for line in outlier_lines]
)
limap.save_obj(
f"tmp/outliers_th_{threshold:.4f}.obj",
outlier_lines_np,
f"tmp/outliers_th_{threshold:.4f}.obj", outlier_lines_np
)


Expand Down
3 changes: 1 addition & 2 deletions scripts/eval_tnt.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ def eval_tnt(cfg, lines, ref_lines=None):
[line.as_array() for line in outlier_lines]
)
limapio.save_obj(
f"tmp/outliers_th_{threshold:.4f}.obj",
outlier_lines_np,
f"tmp/outliers_th_{threshold:.4f}.obj", outlier_lines_np
)


Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/cvg/limap/pull/88/commits/586c5c0434ccac7f09f9b84577670f2da2c9826b

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy