Content-Length: 274831 | pFad | http://github.com/dotnet/tye/pull/789/commits/22e8d03be3b42bd0ec39721359e46f9f0b87067d

F2 Refactor core process extensions by sirh3e · Pull Request #789 · dotnet/tye · GitHub
Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Refactor core process extensions #789

Merged
merged 8 commits into from
Nov 18, 2020
Prev Previous commit
added both missing nit nit: prefer braces around ifs
  • Loading branch information
sirh3e committed Nov 17, 2020
commit 22e8d03be3b42bd0ec39721359e46f9f0b87067d
4 changes: 4 additions & 0 deletions src/Microsoft.Tye.Core/ProcessExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ private static void GetAllChildIdsUnix(int parentId, ISet<int> children, TimeSpa
out var stdout);

if (string.IsNullOrEmpty(stdout))
{
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

}

using var reader = new StringReader(stdout);
while (true)
Expand All @@ -64,7 +66,9 @@ private static void GetAllChildIdsUnix(int parentId, ISet<int> children, TimeSpa
}

if (!int.TryParse(text, out var id))
{
continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer braces around ifs.

}

children.Add(id);
// Recursively get the children
Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/dotnet/tye/pull/789/commits/22e8d03be3b42bd0ec39721359e46f9f0b87067d

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy