This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 520
Refactor core process extensions #789
Merged
jkotalik
merged 8 commits into
dotnet:master
from
sirh3e:refactor-core-process-extensions
Nov 18, 2020
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7130118
refactored ProcessExtensions.cs use of language feature using added i…
sirh3e 912a042
refactored ProcessExtensions.cs removed nested if
sirh3e 617a4ed
refactored ProcessExtensions.cs removed nested if
sirh3e f7e784c
refactored ProcessExtensions.cs removed duplicated quilifer
sirh3e cf4ade9
refactored ProcessExtensions.cs removed conditional access qualifier …
sirh3e f4196f8
refactored ProcessExtensions.cs removed var value is not used
sirh3e 2e76061
refactored ProcessExtensions.cs applied again quiliers missed that it…
sirh3e 22e8d03
added both missing nit nit: prefer braces around ifs
sirh3e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
added both missing nit nit: prefer braces around ifs
- Loading branch information
commit 22e8d03be3b42bd0ec39721359e46f9f0b87067d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,9 @@ private static void GetAllChildIdsUnix(int parentId, ISet<int> children, TimeSpa | |
out var stdout); | ||
|
||
if (string.IsNullOrEmpty(stdout)) | ||
{ | ||
return; | ||
} | ||
|
||
using var reader = new StringReader(stdout); | ||
while (true) | ||
|
@@ -64,7 +66,9 @@ private static void GetAllChildIdsUnix(int parentId, ISet<int> children, TimeSpa | |
} | ||
|
||
if (!int.TryParse(text, out var id)) | ||
{ | ||
continue; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: prefer braces around ifs. |
||
} | ||
|
||
children.Add(id); | ||
// Recursively get the children | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.