Content-Length: 251769 | pFad | http://github.com/emberjs/ember.js/issues/20799

1B Remove component-lookup · Issue #20799 · emberjs/ember.js · GitHub
Skip to content

Remove component-lookup #20799

Open
Open
@chancancode

Description

@chancancode

I am talking about this https://github.com/emberjs/ember.js/blob/main/packages/%40ember/-internals/views/lib/component_lookup.ts

As far as I can tell, it doesn't do anything anymore and haven't for a very long time. Yet we kept the code around and registered it into every application for no reason. That being said it seems to be available through Ember.ComponentLookup (as in import Ember from 'ember';) and the fact that it is registered means it can also be looked up. So straight-up removing the code may cause error in the real world, even though the code doesn't do anything useful anymore. (e.g. in ember-test-helper: https://github.com/emberjs/ember-test-helpers/blob/cbbadbe0b44f6d989990375e300422e8a0a50210/addon/src/-internal/build-registry.ts#L103-L105)

Probably should go around addressing any known consumers and then do an intimate deprecation cycle. Alternatively I suppose it could just piggy back on the deprecation for the component layout resolution thing, though they really aren't related (they used to, when overriding this actually worked).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: http://github.com/emberjs/ember.js/issues/20799

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy