Gradle Configuration Cache - Round 3

Summary: This is the next part of a series of diff needed to enable G. Configuration Cache: https://docs.gradle.org/current/userguide/configuration_cache.html as it will make our CI faster (and will be the default in the future Gradle version). Here I'm removing the `onlyIf` lambdas to make some tasks CC friendly. The problem is that some `onlyIf` lambdas can't easily be serialized. Here I'm cleaning up the problematic one to move the condition checks at execution time Changelog: [Internal] [Changed] - Differential Revision: D69664732
facebook · cortinico · Feb 14, 2025 · Feb 14, 2025 · Feb 14, 2025 · Feb 14, 2025
commit d41f5df826ad8baa7f69c9637e996d0712a63096
diff --git a/...ve-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/internal/BuildCodegenCLITask.kt b/...ve-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/internal/BuildCodegenCLITask.kt
@@ -28,13 +28,19 @@ abstract class BuildCodegenCLITask : Exec() {
 
   @get:Internal abstract val bashWindowsHome: Property<String>
 
+  @get:Internal abstract val rootProjectName: Property<String>
+
   @get:InputFiles abstract val inputFiles: Property<FileTree>
 
   @get:OutputFiles abstract val outputFiles: Property<FileTree>
 
   @get:OutputFile abstract val logFile: RegularFileProperty
 
   override fun exec() {
+    // For build from source scenario, we don't need to build the codegen at all.
+    if (rootProjectName.get() == "react-native-build-from-source") {
+      return
+    }
     val logFileConcrete =
         logFile.get().asFile.apply {
           parentFile.mkdirs()

diff --git a/packages/react-native/ReactAndroid/build.gradle.kts b/packages/react-native/ReactAndroid/build.gradle.kts
@@ -426,10 +426,7 @@ val buildCodegenCLI by
             include("lib/**/*.js")
             include("lib/**/*.js.flow")
           })
-      onlyIf {
-        // For build from source scenario, we don't need to build the codegen at all.
-        rootProject.name != "react-native-build-from-source"
-      }
+      rootProjectName.set(rootProject.name)
     }
 
 /**

diff --git a/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts b/packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts
@@ -124,8 +124,8 @@ val unzipHermes by
 // the two tasks mentioned before, so we install CMake manually to break the circular dependency.
 
 val installCMake by
-    tasks.registering(Exec::class) {
-      onlyIf { !File(cmakePath).exists() }
+    tasks.registering(CustomExecTask::class) {
+      onlyIfProvidedPathDoesNotExists.set(cmakePath)
       commandLine(
           windowsAwareCommandLine(getSDKManagerPath(), "--install", "cmake;${cmakeVersion}"))
     }