Content-Length: 276295 | pFad | http://github.com/flutter/flutter/issues/153556

2D `ResidentWebRunner::attach` calls `ChromeTab::connect` without providing an error handler, risking top-level errors without stack traces · Issue #153556 · flutter/flutter · GitHub
Skip to content

ResidentWebRunner::attach calls ChromeTab::connect without providing an error handler, risking top-level errors without stack traces #153556

@andrewkolos

Description

@andrewkolos

From #153298 (comment) (shortened version):

Looking at this code I also noticed that ResidentWebRunner neglects to pass onError callback to ChromeTab.connect. This seems like an oversight...This callback is used as an onError callback on the WebSocket stream once connection is established. Not passing onError means that all exceptions which occur later (after connection was established and upgraded to WebSocket) are going to be uncaught and will crash Flutter tool as well.

Said another way, we should pass an error handler in this ChromeTab::connect call:

_wipConnection = await chromeTab.connect();

This error handler could simply rethrow the provided error using the provided stack trace using Error.throwWithStackTrace(error, stackTrace).

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-toolOwned by Flutter Tool teamtriaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: http://github.com/flutter/flutter/issues/153556

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy