Flutter Tool reports errors on content-hash #171237
Description
Enabling content hashing for the engine artifacts locally leads to warning from tool about missing git objects.
setup:
mv bin/cache bin/cach.backup # important as tool doens't redownload dart sdk
export FLUTTER_PREBUILT_ENGINE_VERSION=$(./bin/internal/content_aware_hash.sh)
flutter doctoroutput:
Failed to find the latest git commit date: VersionCheckError: Command exited with code 128: git -c log.showSignature=false log 728dc653e5efeb64175acce4bd2d7090781df70a -n 1 --pretty=format:%ad --date=iso
Standard out:
Standard error: fatal: bad object 728dc653e5efeb64175acce4bd2d7090781df70aThis is in the version.dart when trying to get the engineCommitDate:
late final String engineCommitDate = _gitCommitDate(
gitRef: engineRevision,
lenient: true,
workingDirectory: flutterRoot,
);A simple approach would be to look for the log of the last change made to [DEPS, engine/**, bin/internal/release-candidate-branch.version].
git -c log.showSignature=false log -n 1 --pretty=format:%ad --date=iso -- DEPS engine bin/internal/release-candidate-branch.versionAnother option, which could remove git from the pipeline, is recording this information at artifact build time and having it downloaded (e.g. bin/cache/engine_info.yml).