Content-Length: 269341 | pFad | http://github.com/getsentry/sentry-javascript/issues/15709

C1 Attach top level domain to `Failed to fetch` errors. · Issue #15709 · getsentry/sentry-javascript · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach top level domain to Failed to fetch errors. #15709

Open
chargome opened this issue Mar 17, 2025 · 3 comments · May be fixed by #15729
Open

Attach top level domain to Failed to fetch errors. #15709

chargome opened this issue Mar 17, 2025 · 3 comments · May be fixed by #15729
Assignees
@mydea @chargome
Labels
Package: browser Issues related to the Sentry Browser SDK

Comments

@chargome
Copy link
Member

chargome commented Mar 17, 2025 •
edited
Loading

Description

To make Failed to fetch errors without any further error description (mostly for ad-blocked requests) more actionable we want to include the fetch domain to the issue itself.

e.g. TypeError: Failed to fetch would become TypeError: Failed to fetch (some-blocked-third-party.io)
@chargome chargome self-assigned this Mar 17, 2025
@lforst
Copy link
Member

lforst commented Mar 17, 2025

Not 100% sure on the following, but in order not to explode grouping in some cases I would maybe do just the domain name. So Failed to fetch (example.com) - no subdomains or anything. It's also shorter for faster mental parsing.

@chargome chargome changed the title Attach fetch origen to Failed to fetch errors. Attach top level domain to Failed to fetch errors. Mar 17, 2025
@AbhiPrasad AbhiPrasad added the Package: browser Issues related to the Sentry Browser SDK label Mar 17, 2025
@mydea mydea self-assigned this Mar 19, 2025
mydea added a commit that referenced this issue Mar 19, 2025
@mydea
feat(browser): Attach top-level domain to "Failed to fetch" errors
65b835e 
Closes #15709

This also adds tests for the various types of TypeErrors that fetch can produce.
@mydea mydea linked a pull request Mar 19, 2025 that will close this issue
Open
mydea added a commit that referenced this issue Mar 19, 2025
@mydea
feat(browser): Attach top-level domain to "Failed to fetch" errors
307b42b 
Closes #15709

This also adds tests for the various types of TypeErrors that fetch can produce.
chargome pushed a commit that referenced this issue Mar 19, 2025
@mydea @chargome
feat(browser): Attach top-level domain to "Failed to fetch" errors
e3b6bc3 
Closes #15709

This also adds tests for the various types of TypeErrors that fetch can produce.
mydea added a commit that referenced this issue Mar 19, 2025
@mydea
feat(browser): Attach top-level domain to "Failed to fetch" errors
34baf91 
Closes #15709

This also adds tests for the various types of TypeErrors that fetch can produce.
@mrduncan
Copy link
Member

Not 100% sure on the following, but in order not to explode grouping in some cases I would maybe do just the domain name. So Failed to fetch (example.com) - no subdomains or anything. It's also shorter for faster mental parsing.

One thing to watch out for, many domains are not two parts, ex: bbc.co.uk. https://publicsuffix.org/ is the most exhaustive list I'm aware of but that's almost certainly not something we'd want to include in the SDK

@lforst
Copy link
Member

lforst commented Mar 21, 2025

Not 100% sure on the following, but in order not to explode grouping in some cases I would maybe do just the domain name. So Failed to fetch (example.com) - no subdomains or anything. It's also shorter for faster mental parsing.

One thing to watch out for, many domains are not two parts, ex: bbc.co.uk. publicsuffix.org is the most exhaustive list I'm aware of but that's almost certainly not something we'd want to include in the SDK

oh crap that is actually pretty annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

@chargome chargome

Labels
Package: browser Issues related to the Sentry Browser SDK
Projects
None yet
Milestone
No milestone
5 participants
@mrduncan @mydea @lforst @AbhiPrasad @chargome








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/getsentry/sentry-javascript/issues/15709

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy