test: Add edge cases for stream pipe error handling

Add tests for chained stream methods and non-stream pipe objects
github · Napalys · Jun 4, 2025 · May 20, 2025 · May 20, 2025 · May 20, 2025
commit f39bf62fc6a32c9718a222451851dd0e40ce5d79
diff --git a/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.expected b/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.expected
@@ -8,3 +8,10 @@
 | test.js:109:26:109:37 | s.pipe(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
 | test.js:116:5:116:21 | stream.pipe(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
 | test.js:125:5:125:26 | getStre ... e(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:139:5:139:87 | stream. ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:143:5:143:62 | stream. ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:147:5:147:28 | notStre ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:151:20:151:43 | notStre ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:157:47:157:74 | someVar ... ething) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:163:5:163:20 | notStream.pipe() | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
+| test.js:167:5:167:36 | notStre ... , arg3) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
diff --git a/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.js b/javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.js
@@ -134,4 +134,36 @@ function test() {
     stream.pipe(dest);
     stream.once('error', handleError);
   }
+  { // Long chained pipe with error handler
+    const stream = getStream();
+    stream.pause().on('error', handleError).setEncoding('utf8').resume().pipe(writable); // $SPURIOUS:Alert
+  }
+  { // Long chained pipe without error handler
+    const stream = getStream();
+    stream.pause().setEncoding('utf8').resume().pipe(writable); // $Alert
+  }
+  { // Non-stream with pipe method that returns subscribable object (Streams do not have subscribe method)
+    const notStream = getNotAStream();
+    notStream.pipe(writable).subscribe(); // $SPURIOUS:Alert
+  }
+  { // Non-stream with pipe method that returns subscribable object (Streams do not have subscribe method)
+    const notStream = getNotAStream();
+    const result = notStream.pipe(writable); // $SPURIOUS:Alert
+    const dealWithResult = (result) => { result.subscribe(); };
+    dealWithResult(result); 
+  }
+  { // Non-stream with pipe method that returns subscribable object (Streams do not have subscribe method)
+    const notStream = getNotAStream();
+    const pipeIt = (someVariable) => { return someVariable.pipe(something); }; // $SPURIOUS:Alert
+    let x = pipeIt(notStream);
+    x.subscribe(); 
+  }
+  { // Calling custom pipe method with no arguments
+    const notStream = getNotAStream();
+    notStream.pipe(); // $SPURIOUS:Alert
+  }
+  { // Calling custom pipe method with more then 2 arguments
+    const notStream = getNotAStream();
+    notStream.pipe(arg1, arg2, arg3); // $SPURIOUS:Alert
+  }
 }