Content-Length: 276228 | pFad | http://github.com/github/codeql/pull/20048/commits/ea93b392f790f125f648738c46b3f6fb771b1d45

F3 JS: Exclude patched libraries from `xml-bomb` sink by Napalys · Pull Request #20048 · github/codeql · GitHub
Skip to content

JS: Exclude patched libraries from xml-bomb sink #20048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

JS: Exclude patched libraries from xml-bomb sink #20048

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1851deb
Removed `libxmljs` from being marked as `sink` for `xml-bomb`.
Napalys Jul 15, 2025
887d80f
Added change note
Napalys Jul 15, 2025
638f649
Removed `lxml.etree.XMLParser` from xml bomb sinks
Napalys Jul 15, 2025
ea93b39
Added change note for python
Napalys Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added change note for python
  • Loading branch information
@Napalys
Napalys committed Jul 15, 2025
commit ea93b392f790f125f648738c46b3f6fb771b1d45
4 changes: 4 additions & 0 deletions python/ql/lib/change-notes/2025-07-15-xml-bomb-sinks-python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Removed `lxml` as an XML bomb sink. The underlying libxml2 library now includes [entity reference loop detection](https://github.com/lxml/lxml/blob/f33ac2c2f5f9c4c4c1fc47f363be96db308f2fa6/doc/FAQ.txt#L1077) that prevents XML bomb attacks.








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/github/codeql/pull/20048/commits/ea93b392f790f125f648738c46b3f6fb771b1d45

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy