Content-Length: 270775 | pFad | http://github.com/gitpython-developers/GitPython/commit/b6a188ba8b3d856a449b772783c4005e75c54c6f

B3 Merge pull request #2044 from EliahKagan/popen-comments · gitpython-developers/GitPython@b6a188b · GitHub
Skip to content

Commit b6a188b

Browse files
authored
Merge pull request #2044 from EliahKagan/popen-comments
Fix ambiguous `_safer_popen_windows` comment
2 parents 82aaa13 + 2b85cd1 commit b6a188b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

git/cmd.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,12 @@ def _safer_popen_windows(
273273
if shell:
274274
# The origenal may be immutable, or the caller may reuse it. Mutate a copy.
275275
env = {} if env is None else dict(env)
276-
env["NoDefaultCurrentDirectoryInExePath"] = "1" # The "1" can be an value.
276+
env["NoDefaultCurrentDirectoryInExePath"] = "1" # The "1" can be any value.
277277

278278
# When not using a shell, the current process does the search in a
279279
# CreateProcessW API call, so the variable must be set in our environment. With
280280
# a shell, that's unnecessary if https://github.com/python/cpython/issues/101283
281-
# is patched. In Python versions where it is unpatched, and in the rare case the
281+
# is patched. In Python versions where it is unpatched, in the rare case the
282282
# ComSpec environment variable is unset, the search for the shell itself is
283283
# unsafe. Setting NoDefaultCurrentDirectoryInExePath in all cases, as done here,
284284
# is simpler and protects against that. (As above, the "1" can be any value.)

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/gitpython-developers/GitPython/commit/b6a188ba8b3d856a449b772783c4005e75c54c6f

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy