Replies: 2 comments 2 replies
-
Thanks for bringing this up - there is no doubt a use for this in async codebases, but the cost of maintaining that seems too high even with such an enterprising contributor. If there is some potential in this regard, are there ways in python to 'asyncify` otherwise blocking code to make it flow better in async code bases or make it more composable? If so, this might be wroth a contribution to the documentation along the lines of 'GitPython and async'. |
Beta Was this translation helpful? Give feedback.
-
@Byron Can you elaborate on that? This seems like an ideal library for async as it's very io bound and synchronous functions can call async functions, so (as I understand it) it wouldn't be a matter of maintaining both, just porting all the io to async calls. |
Beta Was this translation helpful? Give feedback.
-
|
Since GitPython is in maintenance mode, making such a breaking change is nothing that I'd include in the timeline, only bugfixes are made along with the occasional contributed feature. Thanks for your understanding. |
Beta Was this translation helpful? Give feedback.
-
|
@ahonnecke can I suggest using asgiref? await asgiref.sync.SyncToAsync(git.Repo.clone_from)(url, path)I this work for you, it looks to me like this could be a simple doc contribution. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I have no idea how much work would be required to implement this, but it'd be awesome to be able to
(or something similar -- it's not the end of the world if it has to be a separate method):
I just read the blurb about the status of this project, so totally get that this would only be unlikely to be implemented without an enterprising contributor.
I googled my way to asyncio.create_subprocess_exec, so it's definitely possible, but it seems like it'd be a ton of work to maintain async and non-async interfaces for everything, so I could understand if you'd rather not accept this as a contribution
Beta Was this translation helpful? Give feedback.
All reactions