x/tools/gopls: report error only at function signature for incompatible function literals #72977
Labels
Milestone
Comments
danvolchek
added
gopls
|
For this input package main
func foo(fooer func(int)) {
// ...
}
func main() {
foo(‸₀func(bool) {
// ...
}‸₁)
}the type checker reports a types.Error of this form: (I have replaced positions by numbered markers: ‸₀, etc.) So the question is: should the type checker associate a smaller start/end range with this error, or should gopls post-process the syntax node enclosing that range, perhaps with special cases for FuncLit and other forms that are typically multiline? I would start with the type checker. |
|
We should shorten this in go/types to the function signature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gopls version
go env
Env info
What did you do?
In vscode, passed a function literal with an incompatible signature as an argument to another function, i.e.
here,
fooexpectsfunc(int)but it getsfunc(bool).What did you see happen?
The entire function literal (signature and body) is underlined with red squiggles. The problem is with the signature, but the red squiggles over the entire body make it hard to see where the problem actually is.
I.e.
What did you expect to see?
This is a feature request - it would be nice if only the signature is underlined as the problem.
I.e.
Editor and settings
Logs
No response
The text was updated successfully, but these errors were encountered: