-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oc_config_validate: Support set-replace operations #374
Comments
Ack, somehow we should also offer the possibility to validate configuration changes using SetReplace. A little background: Set and SetGet tests have the intention to validate that small and puntual config changes happen successfully, with minimal impact to other configuration elements. SetUpdate allows to apply a configuration change without affecting other elements not mentioned in the config blob. Also, SetUpdate is used for the InitialConfig so that only the elements in the provided config are applied, leaving all other elements as they are. Using SetUpdate allows to only change what `oc_config_validate' is told to change. If we use SetReplace for InitialConfigs, users then would need to provide a larger JSON config, possibly containing elements not related to the tests (If by accident a leaf of container is omitted, it will either be reset to default or deleted). An approach is to create specifig Testcase Classes The objective of |
Agreed with creating Testcase Classes like I still think an option to set replace the init config makes sense. Consider the following sequence of events when init is sent as update, assuming a continuous testing scenario. These tests could be telemetry, expecting certain update counts, leafs, etc. testgroup.yaml - run at 12PM
testgroup.yaml - run at 1PM
|
Ack, I see the need for controlling how the intiial config is applied. ActionItems:
|
--init_set_replace google#374 Also do small formatting improvements.
--init_set_replace google#374 Also do small formatting improvements.
* Add option to use SetReplace for init configs. --init_set_replace #374 Also do small formatting improvements. * Linting and typing errors fix * Add additional init configs to check SetReplace. There are 2 overlapping init configs applied. When SetReplace, some Tests fail because the last init config deletes what the previous did. * Increase oc_config_validate version to 2.6.2
I wrote the 2nd part of this Issue: #386 |
Closing the feature request as completed. |
Currently tests are hardcoded to use set-update logic, eg:
It would be great if they could support set-replace as well.
This would particularly be useful / important for the init config -- perhaps that can be the first gap to address:
Vendors do not always implement these functions well so they are good to test, or certain bugs are triggered based on which method is used.
The text was updated successfully, but these errors were encountered: