Refactor Backend in assistant a bit

And disable the "Use GPU" toggler if no GPU is detected.
hecrj · hecrj · Feb 1, 2025 · Jan 31, 2025 · Feb 1, 2025 · Feb 1, 2025
commit 912f5b2de69f5984957c6f2f01016f23600eb835
diff --git a/src/data/assistant.rs b/src/data/assistant.rs
@@ -222,7 +222,7 @@ impl Assistant {
                             volume = Self::MODELS_DIR,
                         )
                     }
-                    Backend::Gpu(GpuBackend::Cuda) => {
+                    Backend::Cuda => {
                         format!(
                             "create --rm --gpus all -p {port}:80 -v {volume}:/models \
                             {container} --model /models/{filename} \
@@ -233,7 +233,7 @@ impl Assistant {
                             volume = Self::MODELS_DIR,
                         )
                     }
-                    Backend::Gpu(GpuBackend::Rocm) => {
+                    Backend::Rocm => {
                         format!(
                             "create --rm -p {port}:80 -v {volume}:/models \
                             --device=/dev/kfd --device=/dev/dri \
@@ -497,7 +497,7 @@ impl Assistant {
     ) -> Result<process::Child, Error> {
         let gpu_flags = match backend {
             Backend::Cpu => "",
-            Backend::Gpu(_) => "--gpu-layers 80",
+            Backend::Cuda | Backend::Rocm => "--gpu-layers 80",
         };
 
         let server = process::Command::new(executable)
@@ -525,24 +525,27 @@ impl Assistant {
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum Backend {
     Cpu,
-    Gpu(GpuBackend),
-}
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
-pub enum GpuBackend {
-    Rocm,
     Cuda,
+    Rocm,
 }
 
 impl Backend {
     pub fn detect(graphics_adapter: &str) -> Self {
         if graphics_adapter.contains("NVIDIA") {
-            Self::Gpu(GpuBackend::Cuda)
+            Self::Cuda
         } else if graphics_adapter.contains("AMD") {
-            Self::Gpu(GpuBackend::Rocm)
+            Self::Rocm
         } else {
             Self::Cpu
         }
     }
+
+    pub fn uses_gpu(self) -> bool {
+        match self {
+            Backend::Cuda | Backend::Rocm => true,
+            Backend::Cpu => false,
+        }
+    }
 }
 
 #[derive(Debug, Clone)]

diff --git a/src/screen/boot.rs b/src/screen/boot.rs
@@ -1,4 +1,4 @@
-use crate::data::assistant::{Backend, File, GpuBackend, Model};
+use crate::data::assistant::{Backend, File, Model};
 use crate::widget::tip;
 
 use iced::system;
@@ -13,7 +13,7 @@ pub struct Boot {
     file: Option<File>,
     readme: Vec<markdown::Item>,
     use_gpu: bool,
-    backend: Backend,
+    supported_backend: Backend,
 }
 
 #[derive(Debug, Clone)]
@@ -34,9 +34,10 @@ pub enum Action {
 
 impl Boot {
     pub fn new(model: Model, system: Option<&system::Information>) -> (Self, Task<Message>) {
-        let backend = system
+        let supported_backend = system
             .map(|system| Backend::detect(&system.graphics_adapter))
             .unwrap_or(Backend::Cpu);
+
         (
             Self {
                 model: model.clone(),
@@ -46,8 +47,8 @@ impl Boot {
                     None
                 },
                 readme: Vec::new(),
-                use_gpu: matches!(backend, Backend::Gpu(_)),
-                backend,
+                use_gpu: supported_backend.uses_gpu(),
+                supported_backend,
             },
             Task::future(model.fetch_readme())
                 .and_then(|readme| {
@@ -81,10 +82,10 @@ impl Boot {
                 if let Some(file) = self.file.clone() {
                     Action::Boot {
                         file,
-                        backend: if self.use_gpu && !matches!(self.backend, Backend::Gpu(_)) {
-                            Backend::Gpu(GpuBackend::Cuda)
+                        backend: if self.use_gpu {
+                            self.supported_backend
                         } else {
-                            self.backend
+                            Backend::Cpu
                         },
                     }
                 } else {
@@ -110,9 +111,11 @@ impl Boot {
 
         let boot = {
             let use_cuda = {
-                let toggle = toggler(self.use_gpu)
-                    .label("Use GPU")
-                    .on_toggle(Message::UseGPUToggled);
+                let toggle = toggler(self.use_gpu).label("Use GPU").on_toggle_maybe(
+                    self.supported_backend
+                        .uses_gpu()
+                        .then_some(Message::UseGPUToggled),
+                );
 
                 tip(
                     toggle,