Content-Length: 215575 | pFad | http://github.com/heimdal/heimdal/issues/1172

47 Tests can't be run concurrently from different builds · Issue #1172 · heimdal/heimdal · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests can't be run concurrently from different builds #1172

Open
riastradh opened this issue Jun 21, 2023 · 1 comment
Open

Tests can't be run concurrently from different builds #1172

riastradh opened this issue Jun 21, 2023 · 1 comment

Comments

@riastradh
Copy link

Describe the bug
The Heimdal tests bind to fixed port numbers during the test suite:

heimdal/tests/kdc/Makefile.am

Lines 49 to 56 in ca0e53b

port = 49188
admport = 49189
admport2 = 49190
pwport = 49191
restport = 49192
restport2 = 49193
ipropport = 49194
ipropport2 = 49195

heimdal/tests/kdc/check-cc.in

Lines 51 to 57 in ca0e53b

port=@port@
pwport=@pwport@
kinit="${kinit} --password-file=${objdir}/foopassword ${afs_no_afslog}"
kdestroy="${kdestroy} ${afs_no_unlog}"
kadmin="${kadmin} -l -r $R"
kdc="${kdc} --addresses=localhost -P $port"

Thus, if two instances of the test suite are run concurrently, they may conflict and tests may spuriously fail.

To Reproduce

  1. Build Heimdal in two trees at once.
  2. Run gmake check in both trees simultaneously.

Expected behavior
Concurrent runs of the test suite pass.

Note: This is an separate issue from a single instance of the test suite failing with parallel make jobs, e.g. gmake -j4 check.
@nicowilliams
Copy link
Contributor

Yup. This is a problem. We really need to rationalize all the tests and have them automatically pick port numbers to use.

@riastradh riastradh mentioned this issue Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicowilliams @riastradh








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/heimdal/heimdal/issues/1172

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy