Content-Length: 234100 | pFad | http://github.com/iotaledger/identity.rs/issues/1514

93 [Task] Make IotaTransactionBlockResponse related types exported from iota_interaction_ts and iota_interaction_rust easier to distinguish · Issue #1514 · iotaledger/identity.rs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Make IotaTransactionBlockResponse related types exported from iota_interaction_ts and iota_interaction_rust easier to distinguish #1514

Open
chrisgitiota opened this issue Jan 31, 2025 · 0 comments · May be fixed by #1527
Assignees
Labels
No changelog Excludes PR from becoming part of any changelog

Comments

@chrisgitiota
Copy link

Description

In the current implementation of iota_interaction_ts we have following pub uses in bindings/wasm/iota_interaction_ts/src/lib.rs:

pub use iota_client_ts_sdk::IotaTransactionBlockResponseProvider as IotaTransactionBlockResponseAdapter;

// ...

pub use bindings::IotaTransactionBlockResponseAdapter as AdapterNativeResponse;

The name IotaTransactionBlockResponseAdapter is used for bindings::IotaTransactionBlockResponseAdapter and also as an alias for the exportet iota_client_ts_sdk::IotaTransactionBlockResponseProvider.

This does not result in name clashes but is very confusing.

@chrisgitiota chrisgitiota added the No changelog Excludes PR from becoming part of any changelog label Jan 31, 2025
@chrisgitiota chrisgitiota added this to the v1.6 milestone Jan 31, 2025
@chrisgitiota chrisgitiota self-assigned this Jan 31, 2025
@eike-hass eike-hass moved this from Product Backlog to Sprint Backlog in IOTA Trust Framework Developments Feb 3, 2025
@chrisgitiota chrisgitiota moved this from Sprint Backlog to In Progress in IOTA Trust Framework Developments Feb 13, 2025
@chrisgitiota chrisgitiota moved this from In Progress to In Review in IOTA Trust Framework Developments Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/iotaledger/identity.rs/issues/1514

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy