Content-Length: 228464 | pFad | http://github.com/iotaledger/identity.rs/issues/1519

4D Make signer in WASM32 implementation non-owned again · Issue #1519 · iotaledger/identity.rs · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make signer in WASM32 implementation non-owned again #1519

Open
Tracked by #1445
wulfraem opened this issue Feb 6, 2025 · 0 comments
Open
Tracked by #1445

Make signer in WASM32 implementation non-owned again #1519

wulfraem opened this issue Feb 6, 2025 · 0 comments
Assignees
Labels
Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog

Comments

@wulfraem
Copy link
Contributor

wulfraem commented Feb 6, 2025

The current Storage based signer (src/storage/storage_signer_owned.rs) is owned, which means that it will consume a storage given to it and trying to use the Storage afterward will run into null-pointer errors.

This has some impacts upon usage:

  • null-pointer errors are very un-TypeScript-ish to say the least, and will lead to errors most probably unexpected by implementers
  • avoiding these results in counterintuitive code and examples (e.g. a document has to be created before being allowed to create the identity client, as both need the storage, and the client (currently) takes ownership of it)

Storage signer should be reverted to a model where Storage is not consumed when creating the identity client in TypeScript.

@wulfraem wulfraem added Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Feb 6, 2025
@UMR1352 UMR1352 moved this from Product Backlog to In Progress in IOTA Trust Framework Developments Feb 7, 2025
@UMR1352 UMR1352 self-assigned this Feb 7, 2025
@UMR1352 UMR1352 moved this from In Progress to In Review in IOTA Trust Framework Developments Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Status: In Review
Development

No branches or pull requests

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/iotaledger/identity.rs/issues/1519

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy