Content-Length: 211415 | pFad | http://github.com/jonobr1/two.js/issues/742

4F [Enhancement] Improve TypeScript Types · Issue #742 · jonobr1/two.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Improve TypeScript Types #742

Open
jonobr1 opened this issue Nov 17, 2024 · 2 comments
Open

[Enhancement] Improve TypeScript Types #742

jonobr1 opened this issue Nov 17, 2024 · 2 comments
Labels
enhancement
Milestone
v0.8.x

Comments

@jonobr1
Copy link
Owner

jonobr1 commented Nov 17, 2024

Is your feature request related to a problem? Please describe.
Improve the TypeScript Types definitions of Two.js by:

  1. Moving namespaces -> interfaces
  2. Add fromObject, copy, clone, toObject to all applicable classes
  3. Improve hinting by putting in constant values. E.g: all static Properties lists should be the actual values.

Additional context
This is in the lead-up and concurrent to developing / releasing @react-two library to make Two.js a declarative React compatible component.
@jonobr1
Copy link
Owner Author

jonobr1 commented Nov 17, 2024

Tracking here: https://github.com/jonobr1/two.js/tree/types-improvement

@jonobr1 jonobr1 added this to the v0.8.x milestone Nov 17, 2024
@jonobr1
Copy link
Owner Author

jonobr1 commented Nov 17, 2024

Up to line 2931: https://github.com/jonobr1/two.js/blob/types-improvement/types.d.ts#L2941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.8.x
Development

No branches or pull requests
1 participant
@jonobr1








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/jonobr1/two.js/issues/742

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy