[Fix] jsx-curly-brace-presence: do not trigger on strings containing a quote character

akulsr0 · ljharb · commit 10eb2350a42e · 2024-08-08T19:34:10.000+05:30
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`jsx-curly-brace-presence`]: do not trigger on strings containing a quote character ([#3798][] @akulsr0)
+
+[#3798]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3798
+
 ## [7.35.0] - 2024.07.19
 
 ### Added
diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -269,7 +269,7 @@ module.exports = {
           && !containsMultilineComment(expression.value)
           && !needToEscapeCharacterForJSX(expression.raw, JSXExpressionNode) && (
           jsxUtil.isJSX(JSXExpressionNode.parent)
-          || !containsQuoteCharacters(expression.value)
+          || (!containsQuoteCharacters(expression.value) || typeof expression.value === 'string')
         )
       ) {
         reportUnnecessaryCurly(JSXExpressionNode);
diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js
@@ -934,6 +934,12 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
       errors: [{ messageId: 'unnecessaryCurly' }],
       options: [{ props: 'never', children: 'never', propElementValues: 'never' }],
       features: ['no-ts'],
+    },
+    {
+      code: `<Foo bar={"'"} />`,
+      output: `<Foo bar="'" />`,
+      errors: [{ messageId: 'unnecessaryCurly' }],
+      options: [{ props: 'never', children: 'never', propElementValues: 'never' }],
     }
   )),
 });

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ module.exports = {`
`269`	`269`	`&& !containsMultilineComment(expression.value)`
`270`	`270`	`&& !needToEscapeCharacterForJSX(expression.raw, JSXExpressionNode) && (`
`271`	`271`	`jsxUtil.isJSX(JSXExpressionNode.parent)`
`272`		`- \|\| !containsQuoteCharacters(expression.value)`
	`272`	`+ \|\| (!containsQuoteCharacters(expression.value) \|\| typeof expression.value === 'string')`
`273`	`273`	`)`
`274`	`274`	`) {`
`275`	`275`	`reportUnnecessaryCurly(JSXExpressionNode);`