Content-Length: 266734 | pFad | http://github.com/line/armeria/pull/5969/commits/45dc82b5de645394b03209c1cd59a2913c01e3f9

7C Make ClientRequestContext.authority() and host() return non-null by chickenchickenlove · Pull Request #5969 · line/armeria · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClientRequestContext.authority() and host() return non-null #5969

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make ClientRequestContext.authority() and host() return non-null #5969

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2eae62
ClientRequestContext thorws a exception when host, authoriy is null.
chickenchickenlove Nov 7, 2024
4532087
Handle an exception when host, authority() are called.
chickenchickenlove Nov 7, 2024
6e31ca3
Fixes lint error.
chickenchickenlove Nov 7, 2024
45dc82b
Revert removing @UnstableApi from the function host, authority.
chickenchickenlove Nov 7, 2024
392c249
Remove useless annotation, make a new private method for authority.
chickenchickenlove Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert removing @UnstableApi from the function host, authority.
  • Loading branch information
@chickenchickenlove
chickenchickenlove committed Nov 7, 2024
commit 45dc82b5de645394b03209c1cd59a2913c01e3f9
2 changes: 2 additions & 0 deletions core/src/main/java/com/linecorp/armeria/client/ClientRequestContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,13 @@ ClientRequestContext newDerivedContext(RequestId id, @Nullable HttpRequest req,
* <li>{@link Endpoint#authority()}.</li>
* </ol>
*/
@UnstableApi
String authority();

/**
* Returns the host part of {@link #authority()}, without a port number.
*/
@UnstableApi
String host();

/**
Expand Down
Loading








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/line/armeria/pull/5969/commits/45dc82b5de645394b03209c1cd59a2913c01e3f9

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy