[CIR] Backport VectorType verifier (#1590)

AmrDeveloper · web-flow · commit 1982513c1105 · 2025-04-30T14:48:35.000-07:00
Backport `VectorType::verify` implementation with test for invalid cases
diff --git a/clang/include/clang/CIR/Dialect/IR/CIRTypes.td b/clang/include/clang/CIR/Dialect/IR/CIRTypes.td
@@ -391,6 +391,8 @@ def CIR_VectorType : CIR_Type<"Vector", "vector",
   let assemblyFormat = [{
     `<` $elementType `x` $size `>`
   }];
+
+  let genVerifyDecl = 1;
 }
 
 //===----------------------------------------------------------------------===//
diff --git a/clang/lib/CIR/Dialect/IR/CIRTypes.cpp b/clang/lib/CIR/Dialect/IR/CIRTypes.cpp
@@ -410,6 +410,23 @@ cir::VectorType::getABIAlignment(const ::mlir::DataLayout &dataLayout,
   return llvm::NextPowerOf2(dataLayout.getTypeSizeInBits(*this));
 }
 
+mlir::LogicalResult cir::VectorType::verify(
+    llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
+    mlir::Type elementType, uint64_t size) {
+  if (size == 0)
+    return emitError() << "the number of vector elements must be non-zero";
+
+  // Check if it a valid FixedVectorType
+  if (mlir::isa<cir::PointerType, cir::FP128Type>(elementType))
+    return success();
+
+  // Check if it a valid VectorType
+  if (mlir::isa<cir::IntType>(elementType) ||
+      isAnyFloatingPointType(elementType))
+    return success();
+
+  return emitError() << "unsupported element type for CIR vector";
+}
 // TODO(cir): Implement a way to cache the datalayout info calculated below.
 
 llvm::TypeSize
diff --git a/clang/test/CIR/IR/invalid-vector-zero-size.cir b/clang/test/CIR/IR/invalid-vector-zero-size.cir
@@ -0,0 +1,10 @@
+// RUN: cir-opt %s -verify-diagnostics -split-input-file
+
+!s32i = !cir.int<s, 32>
+
+module  {
+
+// expected-error @below {{the number of vector elements must be non-zero}}
+cir.global external @vec_a = #cir.zero : !cir.vector<!s32i x 0>
+
+}
diff --git a/clang/test/CIR/IR/invalid-vector.cir b/clang/test/CIR/IR/invalid-vector.cir
@@ -0,0 +1,10 @@
+// RUN: cir-opt %s -verify-diagnostics -split-input-file
+
+!s32i = !cir.int<s, 32>
+
+module  {
+
+// expected-error @below {{unsupported element type for CIR vector}}
+cir.global external @vec_b = #cir.zero : !cir.vector<!cir.array<!s32i x 10> x 4>
+
+}

Original file line number	Diff line number	Diff line change
`@@ -391,6 +391,8 @@ def CIR_VectorType : CIR_Type<"Vector", "vector",`
`391`	`391`	`let assemblyFormat = [{`
`392`	`392`	`<` $elementType `x` $size `>`
`393`	`393`	`}];`
	`394`	`+`
	`395`	`+ let genVerifyDecl = 1;`
`394`	`396`	`}`
`395`	`397`
`396`	`398`	`//===----------------------------------------------------------------------===//`