Content-Length: 293517 | pFad | http://github.com/matrix-org/synapse/pull/10097/commits/ac31155c9328c463a229113b8c512fdb202231c8

86 Stop synapse from saving messages in device_inbox for hidden devices. by JohannesKleine · Pull Request #10097 · matrix-org/synapse · GitHub
Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stop synapse from saving messages in device_inbox for hidden devices. #10097

Merged
merged 9 commits into from
Nov 1, 2021
Prev Previous commit
send-to-device events -> to-device messages
  • Loading branch information
anoadragon453 authored Oct 28, 2021
commit ac31155c9328c463a229113b8c512fdb202231c8
2 changes: 1 addition & 1 deletion changelog.d/10097.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fix a bug which allowed hidden devices to receive send-to-device events, resulting in unnecessary database bloat.
Fix a long-standing bug which allowed hidden devices to receive to-device messages, resulting in unnecessary database bloat.
4 changes: 2 additions & 2 deletions synapse/storage/databases/main/deviceinbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ def _add_messages_to_local_device_inbox_txn(
if len(devices) == 1 and devices[0] == "*":
# Handle wildcard device_ids.
# We exclude hidden devices (such as cross-signing keys) here as they are
# not expected to receive send-to-device events.
# not expected to receive to-device messages.
devices = self.db_pool.simple_select_onecol_txn(
txn,
table="devices",
Expand All @@ -504,7 +504,7 @@ def _add_messages_to_local_device_inbox_txn(
continue

# We exclude hidden devices (such as cross-signing keys) here as they are
# not expected to receive send-to-device events.
# not expected to receive to-device messages.
rows = self.db_pool.simple_select_many_txn(
txn,
table="devices",
Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/matrix-org/synapse/pull/10097/commits/ac31155c9328c463a229113b8c512fdb202231c8

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy