Content-Length: 292624 | pFad | http://github.com/namecheap/ilc/pull/230/commits/c55b39eafd429b8503989f0e857fcd3e3f14cb08

A8 Feature/i18n/refactoring and tests by StyleT · Pull Request #230 · namecheap/ilc · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/i18n/refactoring and tests #230

Merged
merged 64 commits into from
Nov 30, 2020
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
3662bea
feat: basic i18n implementation at server side
StyleT Sep 18, 2020
1218f0a
chore: unit tests fix
StyleT Sep 21, 2020
6c637bf
chore: tests added
StyleT Sep 21, 2020
b54c36e
chore: args order fix
StyleT Sep 23, 2020
b31216c
Merge pull request #200 from namecheap/feature/i18n/basic_ssr_impleme…
StyleT Sep 23, 2020
1a45fb4
Merge branch 'master' into feature/i18n/master
StyleT Sep 25, 2020
eebec42
Merge branch 'master' into feature/i18n/master
StyleT Sep 25, 2020
86a84c9
initial client side intl implementation
StyleT Oct 1, 2020
16c0b23
client side intl implementation vol 2
StyleT Oct 6, 2020
b53b8ce
Fetching intl settings from config
StyleT Oct 6, 2020
65477b5
Bugfix & ability to disable i18n feature
StyleT Oct 6, 2020
ba42365
globalSpinner now is enabled by default & is synchronized with langua…
StyleT Oct 6, 2020
51c4a07
Removed location patch
StyleT Oct 9, 2020
8b43607
added x-request-host headers that will be sent to fragments
StyleT Oct 9, 2020
924b27b
typo fix
StyleT Oct 9, 2020
6a49945
tests fix for ClientRouter
StyleT Oct 9, 2020
ec07550
Adjustments to work with Localization from ILC side
StyleT Oct 9, 2020
da5105f
Better error handling during route change
StyleT Oct 9, 2020
2e18c02
fix: fixed performance tracking for special routes
StyleT Oct 9, 2020
838a83f
Fixed work with query params & hash during locale change
StyleT Oct 9, 2020
3c79ea9
Merge branch 'master' into feature/i18n/master
StyleT Oct 12, 2020
0ed629d
Merge branch 'feature/i18n/master' into feature/i18n/client_side_api
StyleT Oct 12, 2020
d9a5049
Added ability to correctly unmount apps
StyleT Oct 12, 2020
e0b6741
Removed unnecessary use of systemSdk
StyleT Oct 12, 2020
df191ad
fixed issue with infinite loop during locale change error
StyleT Oct 12, 2020
d6f4ef7
feat: currency can be changed together with locale
StyleT Oct 13, 2020
96e09bc
ilc-server-sdk -> ilc-sdk
StyleT Oct 13, 2020
5027be5
Fixed props for navbar
StyleT Oct 13, 2020
50a7278
Updated config
StyleT Oct 13, 2020
4f5e392
ilc-sdk update
StyleT Oct 13, 2020
d235fef
Code refactoring
StyleT Oct 15, 2020
3292a4a
iterablePromise fn moved to utils
StyleT Oct 15, 2020
29ee5e8
Code refactoring
StyleT Oct 16, 2020
0b325b8
tests fix
StyleT Oct 19, 2020
90f62be
client side tests fix
StyleT Oct 19, 2020
3e8133f
code refactoring
StyleT Oct 19, 2020
17fc8f5
chore: improved unit tests readability
StyleT Oct 20, 2020
fd40f1f
Merge pull request #215 from namecheap/feature/i18n/client_side_api
StyleT Oct 22, 2020
b025a12
Merge branch 'master' into feature/i18n/master
StyleT Oct 27, 2020
4ce2b1e
feat: global spinner config moved to registry (#218)
StyleT Oct 28, 2020
a63b7bb
feat: I18n settings were moved to Registry (#219)
StyleT Oct 28, 2020
69c252c
Merge branch 'master' into feature/i18n/master
StyleT Oct 29, 2020
303513b
fix: fixed handling of the localized A tags (#224)
StyleT Oct 30, 2020
8c23c9f
chore: better ilc-sdk import
StyleT Nov 5, 2020
690586a
Merge branch 'master' into feature/i18n/master
StyleT Nov 19, 2020
8fe0972
feat: added ability to export "mainSpa" callback as default one
StyleT Nov 19, 2020
4a16717
Merge pull request #229 from namecheap/feature/i18n/default_mainSpa_c…
StyleT Nov 19, 2020
384b9e7
chore: singleSpa.registerApplication() refactor
StyleT Nov 19, 2020
c55b39e
chore: test code removal
StyleT Nov 19, 2020
5dc518e
feat: added corect currency handling
StyleT Nov 23, 2020
b31fa3f
feat: added i18n.routingStrategy settings key
StyleT Nov 23, 2020
f82a80d
chore: registry tests fix
StyleT Nov 23, 2020
a755871
chore: code refactoring
StyleT Nov 23, 2020
0d05a07
chore: better file naming
StyleT Nov 23, 2020
59cae79
feat: Better interface for interaction with apps during language change
StyleT Nov 24, 2020
04b1513
ilc-sdk bump
StyleT Nov 24, 2020
bcea8be
chore: fixed TODO
StyleT Nov 26, 2020
0fd15a3
feat: added special fn for appId to appName/slotName conversion
StyleT Nov 26, 2020
747c1af
feat: improved error handling for i18n config change event
StyleT Nov 26, 2020
615341f
chore: refactoring & tests fix
StyleT Nov 27, 2020
b4c4f64
chore: unused code removal
StyleT Nov 27, 2020
7954c16
chore: centralized appId to name/slotName conversion
StyleT Nov 27, 2020
0addbae
chore: ilc-sdk version bump
StyleT Nov 27, 2020
38a9bbe
chore: code refactoring
StyleT Nov 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: test code removal
  • Loading branch information
StyleT committed Nov 19, 2020
commit c55b39eafd429b8503989f0e857fcd3e3f14cb08
3 changes: 0 additions & 3 deletions ilc/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ selectSlotsToRegister([...registryConf.routes, registryConf.specialRoutes['404']
});
});

//TODO: to be removed
window.__IlcAppSdk = i18n ? new IlcAppSdk({appId: 'tst', intl: i18n.getAdapter()}) : null;

setupErrorHandlers(registryConf, router.getCurrentRoute);
setupPerformanceMonitoring(router.getCurrentRoute);

Expand Down








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/namecheap/ilc/pull/230/commits/c55b39eafd429b8503989f0e857fcd3e3f14cb08

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy