fix: socket variable testing for undefined (#1726)

joamag · LinusU · jimmywarting · web-flow · commit 8bc3a7c85f67 · 2023-06-29T21:15:38.000+02:00
* fix: socket variable testing for undefined
Avoid issue where socket event was not triggered and local socket vraible is not defined.
This issue is reproducible only using deno.

* chore: made socket test capture simpler
Only controls the execution of the section that uses socket.

* Update src/index.js

Co-authored-by: Linus Unnebäck &lt;linus@folkdatorn.se&gt;

* Update index.js

---------

Co-authored-by: Linus Unnebäck &lt;linus@folkdatorn.se&gt;
Co-authored-by: Jimmy Wärting &lt;jimmy@warting.se&gt;
diff --git a/src/index.js b/src/index.js
@@ -362,8 +362,11 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
 		const {headers} = response;
 		if (headers['transfer-encoding'] === 'chunked' && !headers['content-length']) {
 			response.once('close', hadError => {
-				// if a data listener is still present we didn't end cleanly
-				const hasDataListener = socket.listenerCount('data') > 0;
+				// tests for socket presence, as in some situations the
+				// the 'socket' event is not triggered for the request
+				// (happens in deno), avoids `TypeError`
+        // if a data listener is still present we didn't end cleanly
+				const hasDataListener = socket && socket.listenerCount('data') > 0;
 
 				if (hasDataListener && !hadError) {
 					const err = new Error('Premature close');
