Content-Length: 241380 | pFad | http://github.com/node-fetch/node-fetch/issues/599

A2 Ignoring Keep-Alive settings of Global Agent · Issue #599 · node-fetch/node-fetch · GitHub
Skip to content

Ignoring Keep-Alive settings of Global Agent #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshauneu opened this issue Apr 4, 2019 · 3 comments
Open

Ignoring Keep-Alive settings of Global Agent #599

mshauneu opened this issue Apr 4, 2019 · 3 comments

Comments

@mshauneu
Copy link

mshauneu commented Apr 4, 2019

Hello,

AWS approach for configuring is more flexible.

This line prevent to use http(s).globalAgent.options.keepAlive

@bitinn
Copy link
Collaborator

bitinn commented Apr 25, 2019

We might consider changing this default behavior in future, but for now, users have to manage their connection pool by passing us an agent explicitly.

Relevant spec: https://fetch.spec.whatwg.org/#connections

@gunzip
Copy link

gunzip commented Apr 6, 2020

I agree that overriding global agent options causes unexpected behavior for NodeJS devs so getNodeRequestOptions should honor them. This is expecially true when you have to use node-fetch aside other http clients (ie. some cloud sdk) that you want to configure once.

@Prinzhorn
Copy link

I think #1736 kind of fixed this? At least the fact that the underlying keepAlive of the default agent was previously broken by explicitly setting Connection: close.

Or are there any other gotchas when patching the globalAgent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/node-fetch/node-fetch/issues/599

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy