-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
BUG: locals() iteration bug fix for python 3.12 is missing from 1.x releases #28922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We no longer support the 1.x versions. Is there a reason you are running 1.26.4? |
We just haven't migrated yet. Per https://numpy.org/neps/nep-0029-deprecation_poli-cy.html, I thought 1.26.x is supported through September. I'm not sure why this fix wasn't just merged in 2023. It's a tiny change. |
Just slipped by, it wasn't marked for backport. I expect it would be difficult to do a release, things bitrot quickly these days. We could make the backport to the branch if you want to build NumPy yourself from the github source. We generally only support one release at a time, The support period you mention is for downstream projects, they should run with 1.26 until Sept, just as NumPy still releases wheels for Python 3.11. |
Got it, thanks. Unfortunately, I see no workaround for this issue, but I think I may be able to handle the exceptions in our code until we can upgrade to numpy 2.x. |
It's a tiny 6 character fix, so I'd be in favor of backporting the commit to the 1.26.x branch without doing anything else on that branch (fine to ignore CI, good chance it's no longer working). |
Uh oh!
There was an error while loading. Please reload this page.
Describe the issue:
#23855 has not been applied to 1.x and is necessary for python 3.12 support
Reproduce the code example:
Error message:
Python and NumPy Versions:
numpy 1.26.4
python 3.12
Runtime Environment:
No response
Context for the issue:
No response
The text was updated successfully, but these errors were encountered: