Node parameters not parsed correctly when using python composite launch [Foxy] #324
Labels
enhancement
New feature or request
Content-Length: 216303 | pFad | http://github.com/ouster-lidar/ouster-ros/issues/324
4BFetched URL: http://github.com/ouster-lidar/ouster-ros/issues/324
Alternative Proxies:
Is your feature request related to a problem? Please describe.
This also is related to the unresolved part of #212 (comment).
While experimenting with my additions from #323 on the
ros2-foxy
branch, I stumbled upon this issue fromlaunch_ros
ros2/launch_ros#156 when launching the composite mode python launchfile (sensor.composite.launch.py
). The behavior is exactly the same as described in thelaunch_ros
issue:ros__parameters
keys are completely removed from the config (os_sensor_cloud_image_params.yaml
), otherwise the sensor composite node fails to launch.To Reproduce
ros2-foxy
(tested from commit 1d7d506) and configure required parameters inos_sensor_cloud_image_params.yaml
foxy
and source the current workspace.ros2 launch ouster_ros sensor.composite.launch.py
Expected behavior
All composable nodes launch correctly.
Actual behavior
Sensor node fails with missing parameter error:
Describe the solution you'd like
The issue was resolved by ros2/launch_ros#259 in
humble
and onward (which added support for both types of syntax in.yaml
files), but does not appear to be back-ported tofoxy
(the fixing commit is not present in thefoxy
branch history). I am not sure if the fix will get tofoxy
eventually, but I think a quick workaround could be quite straightforward with a pre-processing step that would be added into the launch file:ros__parameters
key and the keys one line above it (this should be quite consistent, since theros__parameters
key doesn't change),ros__parameters
),foxy
, but I think this would be more messy.Targeted Platform (please complete the following information only if applicable, otherwise dot N/A):
foxy
5.15.0-105-generic #115~20.04.1-Ubuntu
x86_64
The text was updated successfully, but these errors were encountered: