Content-Length: 353589 | pFad | http://github.com/purescript/purescript/pull/3845/commits/bdf410b3f9e6306d136d4155fee61442953ccfae

91 Clarify whitespace lex error in qualified identifier lexing by colinwahl · Pull Request #3845 · purescript/purescript · GitHub
Skip to content

Clarify whitespace lex error in qualified identifier lexing #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "space"
This reverts commit 1390079.
  • Loading branch information
Colin Wahl committed Apr 12, 2020
commit bdf410b3f9e6306d136d4155fee61442953ccfae
2 changes: 1 addition & 1 deletion lib/purescript-cst/src/Language/PureScript/CST/Errors.hs
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ prettyPrintErrorMessage (ParserErrorInfo {..}) = case errType of
ErrQualifierLexeme hd | isSpace hd ->
"Unexpected whitespace character " <> displayCodePoint hd <> ", expected qualifier"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you mean ‘expected identifier or operator’ instead of ‘expected qualifier’? The qualifier has already been seen at this point in the parse, right?

Also, it looks like the other error messages of this nature follow an ‘Expected X, saw Y’ pattern; I'd expect these messages to match that.

ErrQualifierLexeme a ->
"Unexpected " <> [ a ] <> ", expected qualifier"
"Unexpected" <> [ a ] <> ", expected qualifier"
ErrLineFeedInString ->
"Unexpected line feed in string literal"
ErrAstralCodePointInChar ->
Expand Down
47 changes: 0 additions & 47 deletions stack.yaml.lock

This file was deleted.

10 changes: 0 additions & 10 deletions tests/purs/failing/3801.out

This file was deleted.

7 changes: 0 additions & 7 deletions tests/purs/failing/3801.purs

This file was deleted.









ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/purescript/purescript/pull/3845/commits/bdf410b3f9e6306d136d4155fee61442953ccfae

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy