Move writing zipfile local header to _ZipWriteFile

python · danifus · Jul 10, 2019 · Jul 10, 2019 · Jul 10, 2019 · Jul 10, 2019
commit 6b90dfd37474ae85d567f0aafc2101ff086aa770
diff --git a/Lib/zipfile.py b/Lib/zipfile.py
@@ -1497,6 +1497,7 @@ def __init__(self, zf, zinfo, zip64):
         self._compress_size = 0
         self._crc = 0
 
+        self.write_local_header()
     @property
     def _fileobj(self):
         return self._zipfile.fp
@@ -1519,6 +1520,8 @@ def get_compressor(self, compress_type, compresslevel=None):
     def writable(self):
         return True
 
+    def write_local_header(self):
+        self.fp.write(zinfo.FileHeader(zip64))
     def write(self, data):
         if self.closed:
             raise ValueError('I/O operation on closed file.')
@@ -1974,9 +1977,6 @@ def _open_to_write(self, zinfo, force_zip64=False):
 
         self._writecheck(zinfo)
         self._didModify = True
-
-        self.fp.write(zinfo.FileHeader(zip64))
-
         self._writing = True
         return self.zipwritefile_cls(self, zinfo, zip64)