Add support for Alter View Rename Column in Postgres v13

yaojiejia · yaojiejia · commit 3fe905a4294e · 2025-05-24T13:20:19.000-04:00
diff --git a/src/sqlancer/postgres/gen/PostgresAlterTableGenerator.java b/src/sqlancer/postgres/gen/PostgresAlterTableGenerator.java
@@ -48,7 +48,7 @@ protected enum Action {
         SET_LOGGED_UNLOGGED, //
         NOT_OF, //
         OWNER_TO, //
-        REPLICA_IDENTITY
+        REPLICA_IDENTITY, ALTER_VIEW_RENAME_COLUMN // RENAME COLUMN old_name TO new_name (for views)
     }
 
     public PostgresAlterTableGenerator(PostgresTable randomTable, PostgresGlobalState globalState,
@@ -98,6 +98,20 @@ public List<Action> getActions(ExpectedErrors errors) {
             // make it more likely that the ALTER TABLE succeeds
             action = Randomly.subset(Randomly.smallNumber(), Action.values());
         }
+
+        // If this is a view, only allow view-compatible operations
+        if (randomTable.isView()) {
+            // Remove all table-specific operations for views
+            action.removeIf(a -> a != Action.ALTER_VIEW_RENAME_COLUMN);
+            // If no view operations remain, add the rename column action
+            if (action.isEmpty()) {
+                action.add(Action.ALTER_VIEW_RENAME_COLUMN);
+            }
+        } else {
+            // Remove view-specific actions if this is a table
+            action.remove(Action.ALTER_VIEW_RENAME_COLUMN);
+        }
+
         if (randomTable.getColumns().size() == 1) {
             action.remove(Action.ALTER_TABLE_DROP_COLUMN);
         }
@@ -120,14 +134,24 @@ public SQLQueryAdapter generate() {
         int i = 0;
         List<Action> action = getActions(errors);
         StringBuilder sb = new StringBuilder();
-        sb.append("ALTER TABLE ");
-        if (Randomly.getBoolean()) {
-            sb.append(" ONLY");
-            errors.add("cannot use ONLY for foreign key on partitioned table");
+
+        // Check if we're dealing with a view operation
+        boolean isViewOperation = action.contains(Action.ALTER_VIEW_RENAME_COLUMN);
+
+        if (isViewOperation) {
+            sb.append("ALTER VIEW ");
+        } else {
+            sb.append("ALTER TABLE ");
+            if (Randomly.getBoolean()) {
+                sb.append(" ONLY");
+                errors.add("cannot use ONLY for foreign key on partitioned table");
+            }
         }
+
         sb.append(" ");
         sb.append(randomTable.getName());
         sb.append(" ");
+
         for (Action a : action) {
             if (i++ != 0) {
                 sb.append(", ");
@@ -364,6 +388,17 @@ public SQLQueryAdapter generate() {
                     errors.add("cannot use invalid index");
                 }
                 break;
+            case ALTER_VIEW_RENAME_COLUMN:
+                sb.append("RENAME COLUMN ");
+                PostgresColumn columnToRename = randomTable.getRandomColumn();
+                sb.append(columnToRename.getName());
+                sb.append(" TO ");
+                sb.append("new_" + columnToRename.getName() + "_" + r.getInteger(1, 1000));
+                errors.add("column does not exist");
+                errors.add("column name already exists");
+                errors.add("cannot rename column of view");
+                errors.add("permission denied");
+                break;
             default:
                 throw new AssertionError(a);
             }
diff --git a/src/sqlancer/postgres/gen/PostgresSetGenerator.java b/src/sqlancer/postgres/gen/PostgresSetGenerator.java
@@ -112,7 +112,7 @@ private enum ConfigurationOption {
         JIT("jit", (r) -> Randomly.fromOptions(1, 0)),
         JOIN_COLLAPSE_LIMIT("join_collapse_limit", (r) -> r.getInteger(1, Integer.MAX_VALUE)),
         PARALLEL_LEADER_PARTICIPATION("parallel_leader_participation", (r) -> Randomly.fromOptions(1, 0)),
-        FORCE_PARALLEL_MODE("force_parallel_mode", (r) -> Randomly.fromOptions("off", "on", "regress")),
+        // FORCE_PARALLEL_MODE("force_parallel_mode", (r) -> Randomly.fromOptions("off", "on", "regress")),
         PLAN_CACHE_MODE("plan_cache_mode",
                 (r) -> Randomly.fromOptions("auto", "force_generic_plan", "force_custom_plan"));
 
