Content-Length: 204240 | pFad | http://github.com/tailscale/tailscale/issues/14747

62 protocol: add a "TerminalError bool" in RegisterResponse · Issue #14747 · tailscale/tailscale · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol: add a "TerminalError bool" in RegisterResponse #14747

Open
bradfitz opened this issue Jan 23, 2025 · 1 comment
Open

protocol: add a "TerminalError bool" in RegisterResponse #14747

bradfitz opened this issue Jan 23, 2025 · 1 comment

Comments

@bradfitz
Copy link
Member

If Tailscale is coming up with an authkey (notably: tsnet.Server.Up) and the auth key is bogus, we kinda just hang right now and don't surface the error.

You can start a subscription to https://pkg.go.dev/tailscale.com/client/tailscale#LocalClient.WatchIPNBusIf you get an ipn.Notify with the Health field set, there will be a ipn.Notify.Health.Warnings map entry with key "login-state" (health.LoginStateWarnable) telling you about the problem, but that's a lot of work just to get an error.

RegisterResponse contains an error string, but that might be due to some ephemeral server load issue, so we don't break the auth state machine and we keep trying.

If we instead had a"TerminalError bool" alongside the error, then we can tear down the state machine and make Up/tsnet.Server.Dial/etc return an error if the authkey is bogus.

/cc @raggi @willnorris @soniaappasamy @andrew-d @sailorfrag

@sailorfrag
Copy link
Member

sailorfrag commented Jan 23, 2025

Feature creep: if MapResponse had a way to signal such errors that would be helpful for things like user suspension or node deletion, triggering a restart of the register/wait-for-auth process.

I guess that could maybe be a C2N call but plumbing that through might be tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/tailscale/tailscale/issues/14747

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy