controlknobs: too much boilerplate to add new ones #14788
Assignees
Comments
bradfitz
added a commit
that referenced
this issue
Jan 26, 2025
…aintenance The AsDebugJSON method (used only for a LocalAPI debug call) always needed to be updated whenever a new controlknob was added. We had a test for it, which was nice, but it was a tedious step we don't need to do. Use reflect instead. Updates #14788 Change-Id: If59cd776920f3ce7c748f86ed2eddd9323039a0b Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
added a commit
that referenced
this issue
Jan 26, 2025
…aintenance The AsDebugJSON method (used only for a LocalAPI debug call) always needed to be updated whenever a new controlknob was added. We had a test for it, which was nice, but it was a tedious step we don't need to do. Use reflect instead. Updates #14788 Change-Id: If59cd776920f3ce7c748f86ed2eddd9323039a0b Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a lot of boilerplate for us to add new controlknobs (which make it possible to disable experimental/risky functionality from the control plane, derisking client releases, knowing we can roll things back to the old behavior if it turns out bad).
This is a tracking bug to make controlknobs easier to add, without so many repetitive steps:
etc
The text was updated successfully, but these errors were encountered: